From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] soc/tegra: fuse: Add custom SoC attributes
Date: Tue, 31 Mar 2020 17:46:04 +0300 [thread overview]
Message-ID: <17fb371a-14f7-360a-48c3-7f079875a8a4@gmail.com> (raw)
In-Reply-To: <bd1b2056-dc72-323b-bda5-d99df3a139a6@nvidia.com>
31.03.2020 16:56, Jon Hunter пишет:
...
>>> +static DEVICE_ATTR(minorrev, S_IRUGO, tegra_soc_minorrev_show, NULL);
>>
>> Checkpatch should give a warning about that permission isn't in octal
>> format, please don't ignore it.
>
> Indeed. Will fix. I thought I had ran this previously, obviously not.
Also, please use DEVICE_ATTR_RO().
prev parent reply other threads:[~2020-03-31 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 10:33 Jon Hunter
2020-03-31 10:33 ` [PATCH V2 2/3] soc/tegra: fuse: Correct Tegra194 revision Jon Hunter
2020-04-17 11:45 ` Jon Hunter
2020-03-31 10:33 ` [PATCH V2 3/3] soc/tegra: fuse: Trivial clean-up of tegra_init_revision() Jon Hunter
2020-03-31 13:39 ` [PATCH V2 1/3] soc/tegra: fuse: Add custom SoC attributes Dmitry Osipenko
2020-03-31 13:56 ` Jon Hunter
2020-03-31 14:46 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17fb371a-14f7-360a-48c3-7f079875a8a4@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®