From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] soc/tegra: fuse: Correct Tegra194 revision
Date: Fri, 17 Apr 2020 12:45:07 +0100 [thread overview]
Message-ID: <b4458eb2-192a-b5a3-8255-e42f9fc52c1a@nvidia.com> (raw)
In-Reply-To: <20200331103341.19571-2-jonathanh@nvidia.com>
On 31/03/2020 11:33, Jon Hunter wrote:
> Determining the revision for Tegra194 devices is slightly different from
> previous generations. For Tegra194, the majorrev field of the HIDREV
> register determines if the major revision is A, B, C, etc and the
> minorrev field determines if the minorrev is 01, 02, 03, etc.
>
> For Tegra194, there are two main revisions which are A01 and A02.
> Therefore, add a new function to correctly identify the revision for
> Tegra194 devices.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/soc/tegra/fuse/fuse-tegra20.c | 3 ++-
> drivers/soc/tegra/fuse/fuse-tegra30.c | 8 ++++++-
> drivers/soc/tegra/fuse/fuse.h | 2 ++
> drivers/soc/tegra/fuse/tegra-apbmisc.c | 29 ++++++++++++++++++++++++++
> 4 files changed, 40 insertions(+), 2 deletions(-)
Although there is a slight difference, it turns out that the existing
code does work fine for Tegra194 as well and so I will drop this change
as it is not needed.
Jon
--
nvpublic
next prev parent reply other threads:[~2020-04-17 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 10:33 [PATCH V2 1/3] soc/tegra: fuse: Add custom SoC attributes Jon Hunter
2020-03-31 10:33 ` [PATCH V2 2/3] soc/tegra: fuse: Correct Tegra194 revision Jon Hunter
2020-04-17 11:45 ` Jon Hunter [this message]
2020-03-31 10:33 ` [PATCH V2 3/3] soc/tegra: fuse: Trivial clean-up of tegra_init_revision() Jon Hunter
2020-03-31 13:39 ` [PATCH V2 1/3] soc/tegra: fuse: Add custom SoC attributes Dmitry Osipenko
2020-03-31 13:56 ` Jon Hunter
2020-03-31 14:46 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4458eb2-192a-b5a3-8255-e42f9fc52c1a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®