mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Don't compile the PMU power driver on 64-bit PowerPC
@ 2007-07-22  0:46 Paul Mackerras
  2007-07-22  1:55 ` Stephen Rothwell
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Mackerras @ 2007-07-22  0:46 UTC (permalink / raw)
  To: linuxppc-dev, linux-kernel

As reported by Stephen Rothwell, an allmodconfig build on 64-bit
PowerPC reports these errors:

ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!

This fixes the problem by not building pmu_battery.ko on ppc64.  There
are no battery-powered ppc64 machines with an Apple PMU, and we can be
reasonably confident there never will be.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 3f6e176..58c806e 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -38,7 +38,7 @@ config BATTERY_DS2760
 
 config BATTERY_PMU
 	tristate "Apple PMU battery"
-	depends on ADB_PMU
+	depends on PPC32 && ADB_PMU
 	help
 	  Say Y here to expose battery information on Apple machines
 	  through the generic battery class.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Don't compile the PMU power driver on 64-bit PowerPC
  2007-07-22  0:46 [PATCH] Don't compile the PMU power driver on 64-bit PowerPC Paul Mackerras
@ 2007-07-22  1:55 ` Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2007-07-22  1:55 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On Sun, 22 Jul 2007 10:46:54 +1000 Paul Mackerras <paulus@samba.org> wrote:
>
> As reported by Stephen Rothwell, an allmodconfig build on 64-bit
> PowerPC reports these errors:
> 
> ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
> ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
> ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!
> 
> This fixes the problem by not building pmu_battery.ko on ppc64.  There
> are no battery-powered ppc64 machines with an Apple PMU, and we can be
> reasonably confident there never will be.
> 
> Signed-off-by: Paul Mackerras <paulus@samba.org>

That fixes it.
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
for what its worth :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-07-22  1:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-22  0:46 [PATCH] Don't compile the PMU power driver on 64-bit PowerPC Paul Mackerras
2007-07-22  1:55 ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®