[RESEND/PATCH] acpi: video: remove unused code

[RESEND/PATCH] acpi: video: remove unused code

[Felipe Contreras]

_BCM_use_index and _BCL_use_index are never used and probably never will.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 drivers/acpi/video.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index e1284b8..e6be27e 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -185,8 +185,6 @@ struct acpi_video_device_cap {
 struct acpi_video_brightness_flags {
 	u8 _BCL_no_ac_battery_levels:1;	/* no AC/Battery levels in _BCL */
 	u8 _BCL_reversed:1;		/* _BCL package is in a reversed order*/
-	u8 _BCL_use_index:1;		/* levels in _BCL are index values */
-	u8 _BCM_use_index:1;		/* input of _BCM is an index value */
 	u8 _BQC_use_index:1;		/* _BQC returns an index value */
 };
 
@@ -806,16 +804,6 @@ acpi_video_init_brightness(struct acpi_video_device *device)
 	br->count = count;
 	device->brightness = br;
 
-	/* Check the input/output of _BQC/_BCL/_BCM */
-	if ((max_level < 100) && (max_level <= (count - 2)))
-		br->flags._BCL_use_index = 1;
-
-	/*
-	 * _BCM is always consistent with _BCL,
-	 * at least for all the laptops we have ever seen.
-	 */
-	br->flags._BCM_use_index = br->flags._BCL_use_index;
-
 	/* _BQC uses INDEX while _BCL uses VALUE in some laptops */
 	br->curr = level = max_level;
 
-- 
1.8.3.269.g65753d8

Re: [RESEND/PATCH] acpi: video: remove unused code

[Felipe Contreras]

On Thu, Aug 22, 2013 at 4:38 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Thursday, August 22, 2013 01:31:11 PM Felipe Contreras wrote:
>> _BCM_use_index and _BCL_use_index are never used and probably never will.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> I have this patch in the linux-next branch, although under a different subject.

Ah, I thought the lack of reply meant it wasn't picked.

-- 
Felipe Contreras

Re: [RESEND/PATCH] acpi: video: remove unused code

[Rafael J. Wysocki]

On Thursday, August 22, 2013 01:31:11 PM Felipe Contreras wrote:
> _BCM_use_index and _BCL_use_index are never used and probably never will.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

I have this patch in the linux-next branch, although under a different subject.

Thanks,
Rafael


> ---
>  drivers/acpi/video.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index e1284b8..e6be27e 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -185,8 +185,6 @@ struct acpi_video_device_cap {
>  struct acpi_video_brightness_flags {
>  	u8 _BCL_no_ac_battery_levels:1;	/* no AC/Battery levels in _BCL */
>  	u8 _BCL_reversed:1;		/* _BCL package is in a reversed order*/
> -	u8 _BCL_use_index:1;		/* levels in _BCL are index values */
> -	u8 _BCM_use_index:1;		/* input of _BCM is an index value */
>  	u8 _BQC_use_index:1;		/* _BQC returns an index value */
>  };
>  
> @@ -806,16 +804,6 @@ acpi_video_init_brightness(struct acpi_video_device *device)
>  	br->count = count;
>  	device->brightness = br;
>  
> -	/* Check the input/output of _BQC/_BCL/_BCM */
> -	if ((max_level < 100) && (max_level <= (count - 2)))
> -		br->flags._BCL_use_index = 1;
> -
> -	/*
> -	 * _BCM is always consistent with _BCL,
> -	 * at least for all the laptops we have ever seen.
> -	 */
> -	br->flags._BCM_use_index = br->flags._BCL_use_index;
> -
>  	/* _BQC uses INDEX while _BCL uses VALUE in some laptops */
>  	br->curr = level = max_level;
>  
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.