From: "Csókás Bence" <csokas.bence@prolan.hu>
To: <wens@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
<dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-sunxi@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Mesih Kilinc <mesihkilinc@gmail.com>,
"Vinod Koul" <vkoul@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk
Date: Mon, 28 Oct 2024 14:12:27 +0100 [thread overview]
Message-ID: <1811aa2a-3d19-4ce4-83c5-863aa0f4daab@prolan.hu> (raw)
In-Reply-To: <CAGb2v65ZXftjrG9+f1_88=EsU7rM8vnOPZCszWfWYFQ+Do9Xsg@mail.gmail.com>
On 2024. 10. 28. 8:44, Chen-Yu Tsai wrote:
> I suggest adding a patch to switch the clk API calls to devm_clk_get_enabled()
> which handles all the cleanup. Similarly you can switch to
>
> devm_reset_control_get_exclusive_deasserted()
>
> for this patch.
>
>
> ChenYu
Huh, that's a new API! Thanks, I'll switch to that then.
Regarding the change to devm_clk_get_enabled(), I think that should be a
separate patch from this series, where all the pre-existing dev_err()'s
get changed as well. If someone wants to work on that, go ahead, but if
no one does then after this series is merged I might get around to that too.
Bence
next prev parent reply other threads:[~2024-10-28 13:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 9:14 [PATCH v2 01/10] dma-engine: sun4i: Add a quirk to support different chips Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk Csókás, Bence
2024-10-27 18:03 ` Csókás Bence
2024-10-27 18:08 ` [PATCH v3 " Csókás, Bence
2024-10-27 20:43 ` Krzysztof Kozlowski
2024-10-28 7:31 ` Csókás Bence
2024-10-28 8:11 ` Krzysztof Kozlowski
2024-10-27 19:12 ` [PATCH v2 " kernel test robot
2024-10-27 20:05 ` kernel test robot
2024-10-27 20:42 ` Krzysztof Kozlowski
2024-10-28 7:37 ` Csókás Bence
2024-10-28 7:44 ` Chen-Yu Tsai
2024-10-28 13:12 ` Csókás Bence [this message]
2024-10-28 16:22 ` Csókás Bence
2024-10-28 8:08 ` Krzysztof Kozlowski
2024-10-27 9:14 ` [PATCH v2 03/10] dt-bindings: dmaengine: Add Allwinner suniv F1C100s DMA Csókás, Bence
2024-10-27 20:40 ` Krzysztof Kozlowski
2024-10-27 9:14 ` [PATCH v2 04/10] dma-engine: sun4i: Add support for Allwinner suniv F1C100s Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 05/10] ARM: dts: suniv: f1c100s: Add support for DMA Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 06/10] ASoC: sun4i-codec: Add DMA Max Burst field Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 07/10] dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 08/10] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 09/10] ARM: dts: suniv: f1c100s: Add support for Audio Codec Csókás, Bence
2024-10-27 9:14 ` [PATCH v2 10/10] ARM: dts: suniv: f1c100s: Activate Audio Codec for Lichee Pi Nano Csókás, Bence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1811aa2a-3d19-4ce4-83c5-863aa0f4daab@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mesihkilinc@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®