mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Csókás Bence" <csokas.bence@prolan.hu>
To: <dmaengine@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-sunxi@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Cc: Mesih Kilinc <mesihkilinc@gmail.com>,
	Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk
Date: Sun, 27 Oct 2024 19:03:55 +0100	[thread overview]
Message-ID: <4b614d6c-6b46-438a-b5c3-de1e69f0feb8@prolan.hu> (raw)
In-Reply-To: <20241027091440.1913863-2-csokas.bence@prolan.hu>



On 2024. 10. 27. 10:14, Csókás, Bence wrote:
> From: Mesih Kilinc <mesihkilinc@gmail.com>
> 
> Allwinner suniv F1C100s has a reset bit for DMA in CCU. Sun4i do not
> has this bit but in order to support suniv we need to add it. So add
> support for reset bit.
> 
> Signed-off-by: Mesih Kilinc <mesihkilinc@gmail.com>
> [ csokas.bence: Rebased and addressed comments ]
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
> ---
> 
> Notes:
>      Changes in v2:
>      * Call reset_control_deassert() unconditionally, as it supports optional resets
>      * Use dev_err_probe()

I missed one, namely:

> +		dev_err(&pdev->dev,
> +			"Failed to deassert the reset control\n");
> +		goto err_clk_disable;
> +	}

For now I'll resubmit just this patch, and then wait for more comments 
that may arise during the week, then resubmit the whole amended series.


  reply	other threads:[~2024-10-27 18:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-27  9:14 [PATCH v2 01/10] dma-engine: sun4i: Add a quirk to support different chips Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk Csókás, Bence
2024-10-27 18:03   ` Csókás Bence [this message]
2024-10-27 18:08     ` [PATCH v3 " Csókás, Bence
2024-10-27 20:43       ` Krzysztof Kozlowski
2024-10-28  7:31         ` Csókás Bence
2024-10-28  8:11           ` Krzysztof Kozlowski
2024-10-27 19:12   ` [PATCH v2 " kernel test robot
2024-10-27 20:05   ` kernel test robot
2024-10-27 20:42   ` Krzysztof Kozlowski
2024-10-28  7:37     ` Csókás Bence
2024-10-28  7:44       ` Chen-Yu Tsai
2024-10-28 13:12         ` Csókás Bence
2024-10-28 16:22           ` Csókás Bence
2024-10-28  8:08       ` Krzysztof Kozlowski
2024-10-27  9:14 ` [PATCH v2 03/10] dt-bindings: dmaengine: Add Allwinner suniv F1C100s DMA Csókás, Bence
2024-10-27 20:40   ` Krzysztof Kozlowski
2024-10-27  9:14 ` [PATCH v2 04/10] dma-engine: sun4i: Add support for Allwinner suniv F1C100s Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 05/10] ARM: dts: suniv: f1c100s: Add support for DMA Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 06/10] ASoC: sun4i-codec: Add DMA Max Burst field Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 07/10] dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 08/10] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 09/10] ARM: dts: suniv: f1c100s: Add support for Audio Codec Csókás, Bence
2024-10-27  9:14 ` [PATCH v2 10/10] ARM: dts: suniv: f1c100s: Activate Audio Codec for Lichee Pi Nano Csókás, Bence

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b614d6c-6b46-438a-b5c3-de1e69f0feb8@prolan.hu \
    --to=csokas.bence@prolan.hu \
    --cc=dmaengine@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mesihkilinc@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=samuel@sholland.org \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®