From: Peter Rosin <peda@axentia.se>
To: Lars-Peter Clausen <lars@metafoo.de>,
"Andrew F. Davis" <afd@ti.com>,
linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Fabio Estevam <festevam@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: afe: unit-converter: add support for adi,lt6106
Date: Mon, 16 Apr 2018 09:29:07 +0200 [thread overview]
Message-ID: <181d76fd-e40c-abd2-7d22-d866c9ab3808@axentia.se> (raw)
In-Reply-To: <6fff0256-c9f6-6302-45ac-afc7a3276b06@metafoo.de>
On 2018-04-13 10:11, Lars-Peter Clausen wrote:
> On 04/13/2018 12:31 AM, Peter Rosin wrote:
>> On 2018-04-12 17:35, Andrew F. Davis wrote:
>>> On 04/12/2018 09:29 AM, Peter Rosin wrote:
>>>> But as I said in the cover letter, I didn't go with sense-gain since I
>>>> thought I would end up with requests for non-integer gains. There is
>>>> yet to be a comment on the non-integer gain problem, and before there
>>>> is a path forward for that case, I'm reluctant.
>>>
>>> Why not similar to what you had before with the resistor:
>>>
>>> sense-gain-multiplier
>>> sense-gain-divider
>>>
>>> if either are missing assume they are 1.
>>
>> Hmm, how about sense-gain for the normal integer case, and then divide
>> by sense-attenuation if needed? I.e. exactly the same functionality as
>> you describe, just different names.
>
> There is some precedence in the clock bindings for using -mult and -div as
> the suffix for fractional scales. See fixed-factor-clock.txt.
Ok, I'm going with sense-gain-mult and sense-gain-div, but I'm going to
diverge a little bit from the clock binding and make them optional with
a default of 1 if missing.
I'm also going to use the compatible "current-sense-amplifier", and not
mention the LT6106, because I suspect that part can conceivable be used
in other ways...
But I'll wait for a bit with this and give everybody a last chance to
pitch suggestions and opinions.
Cheers,
Peter
next prev parent reply other threads:[~2018-04-16 7:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:28 [PATCH v3 0/2] iio: add unit converter Peter Rosin
2018-04-10 15:28 ` [PATCH v3 1/2] dt-bindings: iio: afe: add current-sense-shunt and voltage-divider Peter Rosin
2018-04-13 21:42 ` Rob Herring
2018-04-16 14:00 ` Peter Rosin
2018-04-21 14:34 ` Jonathan Cameron
2018-04-10 15:28 ` [PATCH v3 2/2] iio: afe: unit-converter: new driver Peter Rosin
2018-04-15 17:31 ` Jonathan Cameron
2018-04-16 7:12 ` Peter Rosin
2018-04-18 9:37 ` Jonathan Cameron
2018-04-11 14:15 ` [PATCH v3 0/2] iio: add unit converter Peter Rosin
2018-04-11 14:15 ` [PATCH 1/2] dt-bindings: iio: afe: add binding for adi,lt6106 Peter Rosin
2018-04-16 18:44 ` Rob Herring
2018-04-11 14:15 ` [PATCH 2/2] iio: afe: unit-converter: add support " Peter Rosin
2018-04-11 15:43 ` Andrew F. Davis
2018-04-11 15:51 ` Lars-Peter Clausen
2018-04-11 16:13 ` Andrew F. Davis
2018-04-12 14:29 ` Peter Rosin
2018-04-12 15:35 ` Andrew F. Davis
2018-04-12 22:31 ` Peter Rosin
2018-04-13 8:11 ` Lars-Peter Clausen
2018-04-16 7:29 ` Peter Rosin [this message]
2018-04-13 14:47 ` Andrew F. Davis
2018-04-16 7:17 ` Peter Rosin
2018-04-12 14:04 ` Peter Rosin
2018-04-11 15:34 ` [PATCH v3 0/2] iio: add unit converter Andrew F. Davis
2018-04-15 17:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181d76fd-e40c-abd2-7d22-d866c9ab3808@axentia.se \
--to=peda@axentia.se \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®