From: "Arnd Bergmann" <arnd@arndb.de>
To: "xingtong.wu" <xingtong_wu@163.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Hans de Goede" <hdegoede@redhat.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
"Haeussler, Gerd" <gerd.haeussler.ext@siemens.com>,
"Schaffner, Tobias" <tobias.schaffner@siemens.com>,
"xingtong.wu" <XingTong.Wu@siemens.com>
Subject: Re: [PATCH] watchdog: simatic: add PCI dependency
Date: Mon, 14 Aug 2023 10:48:37 +0200 [thread overview]
Message-ID: <1834eee9-3fbd-4bea-9e22-960ca993303c@app.fastmail.com> (raw)
In-Reply-To: <a6c2f193-ef7c-54a0-dfbb-13915be259a1@163.com>
On Mon, Aug 14, 2023, at 10:27, xingtong.wu wrote:
>>
>> config SIEMENS_SIMATIC_IPC_WDT
>> tristate "Siemens Simatic IPC Watchdog"
>> - depends on SIEMENS_SIMATIC_IPC
>> + depends on SIEMENS_SIMATIC_IPC && PCI
>
> The SIEMENS_SIMATIC_IPC_WDT does not depends on PCI directly,
> it should depends on P2SB, then P2SB depends on PCI
>
>> default y
>> select WATCHDOG_CORE
>> select P2SB
>
> You can replace the "select" to "depends on" instead.
That would also work, but it's generally best not to mix
'depends on' and 'select' for the same symbol. Changing
all three 'select P2SB' to 'depends on P2SB', or removing
the prompt to turn P2SB itself into a hidden symbol is
probably a good follow-up patch, but I'd keep that separate
from the regression fix.
Arnd
next prev parent reply other threads:[~2023-08-14 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 7:38 Arnd Bergmann
2023-08-14 8:27 ` xingtong.wu
2023-08-14 8:48 ` Hans de Goede
2023-08-14 8:48 ` Arnd Bergmann [this message]
2023-08-14 8:50 ` Hans de Goede
2023-08-14 15:28 ` Andy Shevchenko
2023-08-21 11:11 ` Hans de Goede
2023-08-22 14:25 ` Andy Shevchenko
2023-08-14 8:28 ` Hans de Goede
2023-08-14 8:34 ` Hans de Goede
2023-08-14 13:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1834eee9-3fbd-4bea-9e22-960ca993303c@app.fastmail.com \
--to=arnd@arndb.de \
--cc=XingTong.Wu@siemens.com \
--cc=arnd@kernel.org \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
--cc=xingtong_wu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®