From: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jordan Crouse <jordan@cosmicpenguin.net>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/12] drm/msm/disp: pull in common YUV format parameters
Date: Thu, 4 Sep 2025 16:07:05 -0700 [thread overview]
Message-ID: <1865e8a7-9d9d-4671-8429-bff121ab6ac4@oss.qualcomm.com> (raw)
In-Reply-To: <20250705-dpu-formats-v1-6-40f0bb31b8c8@oss.qualcomm.com>
On 7/4/2025 7:47 PM, Dmitry Baryshkov wrote:
> Pull common params of YUV formats into corresponding macro definitions,
> simplifying format table.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/disp/mdp_format.c | 120 ++++++++++++++++------------------
> 1 file changed, 56 insertions(+), 64 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp_format.c b/drivers/gpu/drm/msm/disp/mdp_format.c
> index d577b3d53fbebced63792b5c65f50dd45211c8ea..900b2de252a6eb2eac3d0670f1aaa77f7520fd77 100644
> --- a/drivers/gpu/drm/msm/disp/mdp_format.c
> +++ b/drivers/gpu/drm/msm/disp/mdp_format.c
> @@ -244,27 +244,27 @@ static struct csc_cfg csc_convert[CSC_MAX] = {
> .tile_height = MDP_TILE_HEIGHT_UBWC, \
> }
>
> -#define INTERLEAVED_YUV_FMT(fmt, a, r, g, b, e0, e1, e2, e3, \
> -alpha, chroma, count, bp, flg, fm, np) \
> +#define INTERLEAVED_YUV_FMT(fmt, bp, r, g, b, e0, e1, e2, e3, chroma) \
> { \
> .pixel_format = DRM_FORMAT_ ## fmt, \
> .fetch_type = MDP_PLANE_INTERLEAVED, \
> - .alpha_enable = alpha, \
> + .alpha_enable = false, \
> .element = { (e0), (e1), (e2), (e3)}, \
> .bpc_g_y = g, \
> .bpc_b_cb = b, \
> .bpc_r_cr = r, \
> - .bpc_a = a, \
> + .bpc_a = 0, \
> .chroma_sample = chroma, \
> - .unpack_count = count, \
> + .unpack_count = 4, \
> .bpp = bp, \
> - .fetch_mode = fm, \
> - .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | flg, \
> - .num_planes = np, \
> + .fetch_mode = MDP_FETCH_LINEAR, \
> + .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | \
> + MSM_FORMAT_FLAG_YUV, \
> + .num_planes = 1, \
> .tile_height = MDP_TILE_HEIGHT_DEFAULT \
> }
>
> -#define PSEUDO_YUV_FMT(fmt, a, r, g, b, e0, e1, chroma, flg, fm, np) \
> +#define PSEUDO_YUV_FMT(fmt, r, g, b, e0, e1, chroma) \
> { \
> .pixel_format = DRM_FORMAT_ ## fmt, \
> .fetch_type = MDP_PLANE_PSEUDO_PLANAR, \
> @@ -273,13 +273,14 @@ alpha, chroma, count, bp, flg, fm, np) \
> .bpc_g_y = g, \
> .bpc_b_cb = b, \
> .bpc_r_cr = r, \
> - .bpc_a = a, \
> + .bpc_a = 0, \
> .chroma_sample = chroma, \
> .unpack_count = 2, \
> .bpp = 2, \
> - .fetch_mode = fm, \
> - .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | flg, \
> - .num_planes = np, \
> + .fetch_mode = MDP_FETCH_LINEAR, \
> + .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | \
> + MSM_FORMAT_FLAG_YUV, \
> + .num_planes = 2, \
> .tile_height = MDP_TILE_HEIGHT_DEFAULT \
> }
>
> @@ -303,7 +304,7 @@ flg, fm, np, th) \
> .tile_height = th \
> }
>
> -#define PSEUDO_YUV_FMT_LOOSE(fmt, a, r, g, b, e0, e1, chroma, flg, fm, np)\
> +#define PSEUDO_YUV_FMT_LOOSE(fmt, r, g, b, e0, e1, chroma) \
> { \
> .pixel_format = DRM_FORMAT_ ## fmt, \
> .fetch_type = MDP_PLANE_PSEUDO_PLANAR, \
> @@ -312,13 +313,15 @@ flg, fm, np, th) \
> .bpc_g_y = g, \
> .bpc_b_cb = b, \
> .bpc_r_cr = r, \
> - .bpc_a = a, \
> + .bpc_a = 0, \
> .chroma_sample = chroma, \
> .unpack_count = 2, \
> .bpp = 2, \
> - .fetch_mode = fm, \
> - .flags = MSM_FORMAT_FLAG_UNPACK_ALIGN_MSB | flg, \
> - .num_planes = np, \
> + .fetch_mode = MDP_FETCH_LINEAR, \
> + .flags = MSM_FORMAT_FLAG_UNPACK_ALIGN_MSB | \
> + MSM_FORMAT_FLAG_DX | \
> + MSM_FORMAT_FLAG_YUV, \
> + .num_planes = 2, \
> .tile_height = MDP_TILE_HEIGHT_DEFAULT \
> }
>
> @@ -342,23 +345,23 @@ flg, fm, np, th) \
> .tile_height = th \
> }
>
> -#define PLANAR_YUV_FMT(fmt, a, r, g, b, e0, e1, e2, alpha, chroma, bp, \
> -flg, fm, np) \
> +#define PLANAR_YUV_FMT(fmt, bp, r, g, b, e0, e1, e2, chroma) \
> { \
> .pixel_format = DRM_FORMAT_ ## fmt, \
> .fetch_type = MDP_PLANE_PLANAR, \
> - .alpha_enable = alpha, \
> + .alpha_enable = false, \
> .element = { (e0), (e1), (e2), 0 }, \
> .bpc_g_y = g, \
> .bpc_b_cb = b, \
> .bpc_r_cr = r, \
> - .bpc_a = a, \
> + .bpc_a = 0, \
> .chroma_sample = chroma, \
> .unpack_count = 1, \
> .bpp = bp, \
> - .fetch_mode = fm, \
> - .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | flg, \
> - .num_planes = np, \
> + .fetch_mode = MDP_FETCH_LINEAR, \
> + .flags = MSM_FORMAT_FLAG_UNPACK_TIGHT | \
> + MSM_FORMAT_FLAG_YUV, \
> + .num_planes = 3, \
> .tile_height = MDP_TILE_HEIGHT_DEFAULT \
> }
>
> @@ -511,72 +514,61 @@ static const struct msm_format mdp_formats[] = {
>
> /* 2 plane YUV */
> PSEUDO_YUV_FMT(NV12,
> - 0, BPC8, BPC8, BPC8,
> + BPC8, BPC8, BPC8,
> C1_B_Cb, C2_R_Cr,
> - CHROMA_420, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 2),
> + CHROMA_420),
>
> PSEUDO_YUV_FMT(NV21,
> - 0, BPC8, BPC8, BPC8,
> + BPC8, BPC8, BPC8,
> C2_R_Cr, C1_B_Cb,
> - CHROMA_420, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 2),
> + CHROMA_420),
>
> PSEUDO_YUV_FMT(NV16,
> - 0, BPC8, BPC8, BPC8,
> + BPC8, BPC8, BPC8,
> C1_B_Cb, C2_R_Cr,
> - CHROMA_H2V1, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 2),
> + CHROMA_H2V1),
>
> PSEUDO_YUV_FMT(NV61,
> - 0, BPC8, BPC8, BPC8,
> + BPC8, BPC8, BPC8,
> C2_R_Cr, C1_B_Cb,
> - CHROMA_H2V1, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 2),
> + CHROMA_H2V1),
>
> PSEUDO_YUV_FMT_LOOSE(P010,
> - 0, BPC8, BPC8, BPC8,
> + BPC8, BPC8, BPC8,
> C1_B_Cb, C2_R_Cr,
> - CHROMA_420, MSM_FORMAT_FLAG_DX | MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 2),
> + CHROMA_420),
>
> /* 1 plane YUV */
> - INTERLEAVED_YUV_FMT(VYUY,
> - 0, BPC8, BPC8, BPC8,
> + INTERLEAVED_YUV_FMT(VYUY, 2,
> + BPC8, BPC8, BPC8,
> C2_R_Cr, C0_G_Y, C1_B_Cb, C0_G_Y,
> - false, CHROMA_H2V1, 4, 2, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 1),
> + CHROMA_H2V1),
>
> - INTERLEAVED_YUV_FMT(UYVY,
> - 0, BPC8, BPC8, BPC8,
> + INTERLEAVED_YUV_FMT(UYVY, 2,
> + BPC8, BPC8, BPC8,
> C1_B_Cb, C0_G_Y, C2_R_Cr, C0_G_Y,
> - false, CHROMA_H2V1, 4, 2, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 1),
> + CHROMA_H2V1),
>
> - INTERLEAVED_YUV_FMT(YUYV,
> - 0, BPC8, BPC8, BPC8,
> + INTERLEAVED_YUV_FMT(YUYV, 2,
> + BPC8, BPC8, BPC8,
> C0_G_Y, C1_B_Cb, C0_G_Y, C2_R_Cr,
> - false, CHROMA_H2V1, 4, 2, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 1),
> + CHROMA_H2V1),
>
> - INTERLEAVED_YUV_FMT(YVYU,
> - 0, BPC8, BPC8, BPC8,
> + INTERLEAVED_YUV_FMT(YVYU, 2,
> + BPC8, BPC8, BPC8,
> C0_G_Y, C2_R_Cr, C0_G_Y, C1_B_Cb,
> - false, CHROMA_H2V1, 4, 2, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 1),
> + CHROMA_H2V1),
>
> /* 3 plane YUV */
> - PLANAR_YUV_FMT(YUV420,
> - 0, BPC8, BPC8, BPC8,
> + PLANAR_YUV_FMT(YUV420, 1,
> + BPC8, BPC8, BPC8,
> C2_R_Cr, C1_B_Cb, C0_G_Y,
> - false, CHROMA_420, 1, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 3),
> + CHROMA_420),
>
> - PLANAR_YUV_FMT(YVU420,
> - 0, BPC8, BPC8, BPC8,
> + PLANAR_YUV_FMT(YVU420, 1,
> + BPC8, BPC8, BPC8,
> C1_B_Cb, C2_R_Cr, C0_G_Y,
> - false, CHROMA_420, 1, MSM_FORMAT_FLAG_YUV,
> - MDP_FETCH_LINEAR, 3),
> + CHROMA_420),
> };
>
> /*
>
next prev parent reply other threads:[~2025-09-04 23:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-05 2:47 [PATCH 00/12] drm/msm/dpu: rework format handling code Dmitry Baryshkov
2025-07-05 2:47 ` [PATCH 01/12] drm/msm/disp: set num_planes to 1 for interleaved YUV formats Dmitry Baryshkov
2025-09-04 18:39 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 02/12] drm/msm/disp: set num_planes and fetch_mode in INTERLEAVED_RGB_FMT Dmitry Baryshkov
2025-09-04 21:35 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 03/12] drm/msm/disp: set num_planes, fetch_mode and tile_height in INTERLEAVED_RGB_FMT_TILED Dmitry Baryshkov
2025-07-05 2:47 ` [PATCH 04/12] drm/msm/disp: simplify RGB{,A,X} formats definitions Dmitry Baryshkov
2025-09-04 23:05 ` Jessica Zhang
2025-09-04 23:06 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 05/12] drm/msm/disp: simplify tiled " Dmitry Baryshkov
2025-09-04 23:06 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 06/12] drm/msm/disp: pull in common YUV format parameters Dmitry Baryshkov
2025-09-04 23:07 ` Jessica Zhang [this message]
2025-07-05 2:47 ` [PATCH 07/12] drm/msm/disp: pull in common tiled " Dmitry Baryshkov
2025-09-04 22:22 ` Jessica Zhang
2025-09-04 22:37 ` Dmitry Baryshkov
2025-07-05 2:47 ` [PATCH 08/12] drm/msm/disp: drop PSEUDO_YUV_FMT_LOOSE_TILED Dmitry Baryshkov
2025-09-04 23:04 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 09/12] drm/msm/dpu: simplify _dpu_format_populate_plane_sizes_* Dmitry Baryshkov
2025-09-04 23:19 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 10/12] drm/msm/dpu: drop redundant num_planes assignment in _dpu_format_populate_plane_sizes*() Dmitry Baryshkov
2025-09-04 23:19 ` Jessica Zhang
2025-07-05 2:47 ` [PATCH 11/12] drm/msm/dpu: rewrite _dpu_format_populate_plane_sizes_ubwc() Dmitry Baryshkov
2025-07-05 17:53 ` kernel test robot
2025-07-05 2:47 ` [PATCH 12/12] drm/msm/dpu: use standard functions in _dpu_format_populate_plane_sizes_ubwc() Dmitry Baryshkov
2025-09-04 18:38 ` Jessica Zhang
2025-09-04 20:19 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1865e8a7-9d9d-4671-8429-bff121ab6ac4@oss.qualcomm.com \
--to=jessica.zhang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®