From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, Sudeep.KarkadaNagesha@arm.com,
Robin.Randhawa@arm.com, Arvind.Chauhan@arm.com
Subject: Re: [PATCH] cpufreq:core: Fix printing of governor and driver name
Date: Tue, 16 Oct 2012 18:20:48 +0200 [thread overview]
Message-ID: <1873742.zv8KVPIaZX@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpomJcN3aLefUOhJ+28PkqhjzKU9Qjk43xMTxhvvBNf8G+Q@mail.gmail.com>
On Tuesday 16 of October 2012 09:09:15 Viresh Kumar wrote:
> On 15 October 2012 23:21, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday 10 of October 2012 10:12:11 Viresh Kumar wrote:
> >> Arrays for governer and driver name are of size CPUFREQ_NAME_LEN or 16.
> >> i.e. 15 bytes for name and 1 for trailing '\0'.
> >>
> >> When cpufreq driver print these names (for sysfs), it includes '\n' or ' ' in
> >> the fmt string and still passes length as CPUFREQ_NAME_LEN. If the driver or
> >> governor names are using all 15 fields allocated to them, then the trailing '\n'
> >> or ' ' will never be printed. And so commands like:
> >>
> >> root@linaro-developer# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver
> >>
> >> will print something like:
> >>
> >> cpufreq_foodrvroot@linaro-developer#
> >>
> >> Fix this by increasing print length by one character.
> >>
> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Thanks for the patch, I'll queue it up for v3.8.
>
> Hi Rafael,
>
> Thanks for accepting the patch.
> I thought both of my patches would go in 3.7-rc2 as they are bug
> fixes. Isn't that correct?
They don't fix serious bugs, though, so they don't look like urgent.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2012-10-16 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 4:42 Viresh Kumar
2012-10-15 17:51 ` Rafael J. Wysocki
2012-10-16 3:39 ` Viresh Kumar
2012-10-16 16:20 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1873742.zv8KVPIaZX@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Arvind.Chauhan@arm.com \
--cc=Robin.Randhawa@arm.com \
--cc=Sudeep.KarkadaNagesha@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®