mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Brad Hubbard <bhubbard@redhat.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: zyan@redhat.com, sage@redhat.com
Subject: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings
Date: Sun, 16 Aug 2015 21:05:37 -0400 (EDT)	[thread overview]
Message-ID: <1876245679.2939973.1439773537944.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1548910686.2935580.1439772740199.JavaMail.zimbra@redhat.com>

    ceph: remove redundant test of head->safe and silence static analysis warnings

    Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
---
 fs/ceph/mds_client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 6aa07af..6e196ee 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)
                mutex_unlock(&mdsc->mutex);
                goto out;
        }
-       if (req->r_got_safe && !head->safe) {
+       if (req->r_got_safe) {
                pr_warn("got unsafe after safe on %llu from mds%d\n",
                           tid, mds);
                mutex_unlock(&mdsc->mutex);
-- 

       reply	other threads:[~2015-08-17  1:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1548910686.2935580.1439772740199.JavaMail.zimbra@redhat.com>
2015-08-17  1:05 ` Brad Hubbard [this message]
2015-08-18  2:34   ` Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1876245679.2939973.1439773537944.JavaMail.zimbra@redhat.com \
    --to=bhubbard@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sage@redhat.com \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome