* [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings [not found] <1548910686.2935580.1439772740199.JavaMail.zimbra@redhat.com> @ 2015-08-17 1:05 ` Brad Hubbard 2015-08-18 2:34 ` Yan, Zheng 0 siblings, 1 reply; 2+ messages in thread From: Brad Hubbard @ 2015-08-17 1:05 UTC (permalink / raw) To: linux-kernel; +Cc: zyan, sage ceph: remove redundant test of head->safe and silence static analysis warnings Signed-off-by: Brad Hubbard <bhubbard@redhat.com> --- fs/ceph/mds_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 6aa07af..6e196ee 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) mutex_unlock(&mdsc->mutex); goto out; } - if (req->r_got_safe && !head->safe) { + if (req->r_got_safe) { pr_warn("got unsafe after safe on %llu from mds%d\n", tid, mds); mutex_unlock(&mdsc->mutex); -- ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings 2015-08-17 1:05 ` [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings Brad Hubbard @ 2015-08-18 2:34 ` Yan, Zheng 0 siblings, 0 replies; 2+ messages in thread From: Yan, Zheng @ 2015-08-18 2:34 UTC (permalink / raw) To: Brad Hubbard; +Cc: linux-kernel, sage > On Aug 17, 2015, at 09:05, Brad Hubbard <bhubbard@redhat.com> wrote: > > ceph: remove redundant test of head->safe and silence static analysis warnings > > Signed-off-by: Brad Hubbard <bhubbard@redhat.com> > --- > fs/ceph/mds_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index 6aa07af..6e196ee 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) > mutex_unlock(&mdsc->mutex); > goto out; > } > - if (req->r_got_safe && !head->safe) { > + if (req->r_got_safe) { > pr_warn("got unsafe after safe on %llu from mds%d\n", > tid, mds); > mutex_unlock(&mdsc->mutex); > -- added to our testing branch, Thanks Yan, Zheng ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-18 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1548910686.2935580.1439772740199.JavaMail.zimbra@redhat.com>
2015-08-17 1:05 ` [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings Brad Hubbard
2015-08-18 2:34 ` Yan, Zheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome