From: Carlos Bilbao <bilbao@vt.edu>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Christoph Hellwig <hch@lst.de>
Cc: "Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
daniel.almeida@collabora.com, aliceryhl@google.com,
robin.murphy@arm.com, rust-for-linux@vger.kernel.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Valentin Obst" <kernel@valentinobst.de>,
"open list" <linux-kernel@vger.kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
airlied@redhat.com,
"open list:DMA MAPPING HELPERS" <iommu@lists.linux.dev>,
"Greg KH" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.
Date: Sat, 8 Feb 2025 17:55:16 -0600 [thread overview]
Message-ID: <1894f095-e93a-4def-a223-d5c089ecc2df@vt.edu> (raw)
In-Reply-To: <CANiq72=R2N+QiCiHZQu-6YJ9aYpn_bik3BW3U=nAW3jL7unzLw@mail.gmail.com>
Hello,
On 1/8/25 09:16, Miguel Ojeda wrote:
> On Wed, Jan 8, 2025 at 3:00 PM Christoph Hellwig <hch@lst.de> wrote:
>>
>> No rust code in kernel/dma, please.
>
> What do you suggest?
This is it. What do people suggest? This thread has received a lot of
attention -- maybe it's an opportunity for the community to brainstorm.
Here's an idea:
Some maintainers clearly hate wrappers/bindings to Rust, while others don't
mind as long as the R4L folks commit to the maintenance duties. Depending on
the subsystem, it will be a completely different conversation. It seems to
me that right now, every time the R4L folks interact with a new subsystem,
they need to understand the maintainer's stance. That looks like an
exhausting process.
Would it make sense to have a C middleman that Rust calls instead of
binding directly to the C funcs? This dispatcher would provide a simpler,
stable API with fixed function signatures, even if the C functions change.
If a C func is removed/changed, only the C dispatcher would need to be
adapted, but until that happens, a new error could be returned to the Rust
side (not ideal, but Rust doesn't just break).
This would obviously impose some limitations on the Rust side, but it might
be less conflictive than direct bindings. Also, in Abdiel's case here (for
example), he'd explicitly take on the maintenance of the Rust abstraction
and its DMA dispatchers, leaving no ambiguity about ownership.
>
> Thanks!
>
> Cheers,
> Miguel
>
>
Thanks,
Carlos
next prev parent reply other threads:[~2025-02-08 23:55 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 12:27 [PATCH v8 0/2] Add " Abdiel Janulgue
2025-01-08 12:27 ` [PATCH v8 1/2] rust: error: Add EOVERFLOW Abdiel Janulgue
2025-01-08 12:27 ` [PATCH v8 2/2] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-01-08 13:59 ` Christoph Hellwig
2025-01-08 15:16 ` Miguel Ojeda
2025-01-08 15:18 ` Christoph Hellwig
2025-01-08 15:21 ` Danilo Krummrich
2025-01-09 8:08 ` Christoph Hellwig
2025-01-09 8:49 ` Danilo Krummrich
2025-01-10 8:39 ` Christoph Hellwig
2025-01-10 10:41 ` Danilo Krummrich
2025-01-16 13:17 ` Danilo Krummrich
2025-01-16 13:57 ` Robin Murphy
2025-01-16 15:57 ` Danilo Krummrich
2025-01-17 13:56 ` Simona Vetter
2025-01-17 19:10 ` Abdiel Janulgue
2025-01-28 10:14 ` Daniel Almeida
2025-01-28 9:23 ` Christoph Hellwig
2025-01-29 21:33 ` Danilo Krummrich
2025-01-31 7:57 ` Christoph Hellwig
2025-02-03 8:17 ` Abdiel Janulgue
2025-02-04 5:29 ` Christoph Hellwig
2025-01-30 13:19 ` Philipp Stanner
2025-01-30 13:35 ` Daniel Almeida
2025-01-30 13:43 ` Philipp Stanner
2025-01-30 15:46 ` Jason Gunthorpe
2025-01-30 16:11 ` Greg KH
2025-01-30 17:24 ` Jason Gunthorpe
2025-01-31 7:47 ` Greg KH
2025-01-31 13:54 ` Jason Gunthorpe
2025-02-03 18:46 ` Hector Martin
2025-02-03 19:16 ` Jason Gunthorpe
2025-02-03 23:41 ` Hector Martin
2025-02-03 19:22 ` Paolo Bonzini
2025-02-03 23:05 ` Hector Martin
2025-02-05 18:52 ` On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.) Simona Vetter
2025-02-05 20:36 ` Dave Airlie
2025-02-06 9:19 ` Hector Martin
2025-02-06 17:58 ` Linus Torvalds
2025-02-07 12:16 ` Dr. Greg
2025-02-08 4:26 ` Steven Rostedt
2025-02-08 4:32 ` Steven Rostedt
2025-02-08 8:31 ` Hector Martin
2025-02-10 9:41 ` Icenowy Zheng
2025-02-10 10:24 ` Danilo Krummrich
2025-02-13 3:49 ` Icenowy Zheng
2025-02-13 6:41 ` Abdiel Janulgue
2025-02-13 9:50 ` Icenowy Zheng
2025-02-13 11:34 ` Danilo Krummrich
2025-02-08 20:44 ` Theodore Ts'o
2025-02-09 0:47 ` Danilo Krummrich
2025-02-09 3:42 ` comex
2025-02-13 10:20 ` David Airlie
2025-02-20 16:24 ` Simona Vetter
2025-02-20 16:37 ` Jason Gunthorpe
2025-02-20 16:52 ` Jarkko Sakkinen
2025-02-13 19:52 ` Ronja Meyer
2025-02-13 19:22 ` 33KK
2025-02-06 19:37 ` Danilo Krummrich
2025-02-06 20:16 ` Hector Martin
2025-02-07 17:14 ` Konstantin Ryabitsev
2025-02-07 18:02 ` Hector Martin
2025-02-07 18:16 ` Konstantin Ryabitsev
2025-02-09 8:25 ` Neal Gompa
2025-02-10 17:28 ` Mark Brown
2025-02-14 7:10 ` Neal Gompa
2025-02-14 19:49 ` Al Viro
2025-02-19 15:03 ` Mark Brown
2025-02-07 18:33 ` Linus Torvalds
2025-02-07 19:18 ` Hector Martin
2025-02-07 18:53 ` Dr. David Alan Gilbert
2025-02-07 9:41 ` Hector Martin
2025-02-07 10:20 ` Hector Martin
2025-02-07 10:51 ` Greg KH
2025-02-07 13:49 ` Simona Vetter
2025-02-07 14:54 ` Hector Martin
2025-02-10 7:52 ` Simona Vetter
2025-02-08 23:55 ` Carlos Bilbao [this message]
2025-02-09 6:44 ` [PATCH v8 2/2] rust: add dma coherent allocator abstraction David Airlie
2025-02-09 16:19 ` Carlos Bilbao
2025-02-09 16:28 ` Carlos Bilbao
2025-01-08 18:08 ` Daniel Sedlak
2025-01-08 19:09 ` Daniel Almeida
2025-01-09 11:14 ` Abdiel Janulgue
2025-01-09 11:19 ` Miguel Ojeda
2025-01-09 11:32 ` Miguel Ojeda
2025-01-10 8:07 ` Abdiel Janulgue
2025-01-12 0:41 ` kernel test robot
2025-02-04 16:54 ` Thomas Hampton
2025-02-05 2:41 ` Thomas Hampton
2025-02-10 8:54 ` [PATCH v8 0/2] Add " Pyrex
2025-02-10 9:09 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894f095-e93a-4def-a223-d5c089ecc2df@vt.edu \
--to=bilbao@vt.edu \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=airlied@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome