From: Christophe Kerello <christophe.kerello@foss.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 05/12] memory: stm32-fmc2-ebi: update the driver to support revision 2
Date: Tue, 13 Feb 2024 13:36:16 +0100 [thread overview]
Message-ID: <18ec4d01-717e-440b-bc54-8652fb68965e@foss.st.com> (raw)
In-Reply-To: <6bc91742-66d8-425b-ba40-fe5fa6ba18c4@linaro.org>
On 2/13/24 08:46, Krzysztof Kozlowski wrote:
> The function is not really readable anymore. Please split it into three
> functions: for v1 (so original code), v2 and wrapper choosing it based
> on revision). Or two functions and some sort of ops with function
> pointers (so you call ops->check_clk_period). Or just parametrize the
> registers with two different "struct reg_field" and use appropriate one
> for given revision (the code looks the same!)
> Or just two set of stm32_fmc2_child_props...
>
> Anyway the duplicated code just two read different register is it not
> the way to go.
Hi Krzysztof,
As I said in patch 4, I am going to rewrite this patch and I am going to
use the platform data to distinguish between each variant instead of
checking the IP revision.
Regards,
Christophe Kerello.
next prev parent reply other threads:[~2024-02-13 12:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:48 [PATCH 00/12] Add MP25 FMC2 support Christophe Kerello
2024-02-12 17:48 ` [PATCH 01/12] dt-bindings: memory-controller: st,stm32: add MP25 support Christophe Kerello
2024-02-12 18:30 ` Conor Dooley
2024-02-13 10:56 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 02/12] dt-bindings: memory-controller: st,stm32: add 'power-domains' property Christophe Kerello
2024-02-12 18:33 ` Conor Dooley
2024-02-13 10:57 ` Christophe Kerello
2024-02-13 11:57 ` Krzysztof Kozlowski
2024-02-13 15:57 ` Christophe Kerello
2024-02-14 10:07 ` Krzysztof Kozlowski
2024-02-12 17:48 ` [PATCH 03/12] memory: stm32-fmc2-ebi: add a platform data structure Christophe Kerello
2024-02-12 17:48 ` [PATCH 04/12] memory: stm32-fmc2-ebi: add MP25 support Christophe Kerello
2024-02-13 7:36 ` Krzysztof Kozlowski
2024-02-13 12:29 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 05/12] memory: stm32-fmc2-ebi: update the driver to support revision 2 Christophe Kerello
2024-02-13 7:46 ` Krzysztof Kozlowski
2024-02-13 12:36 ` Christophe Kerello [this message]
2024-02-12 17:48 ` [PATCH 06/12] memory: stm32-fmc2-ebi: add RIF support Christophe Kerello
2024-02-13 7:52 ` Krzysztof Kozlowski
2024-02-13 13:15 ` Christophe Kerello
2024-02-14 10:07 ` Krzysztof Kozlowski
2024-02-15 9:00 ` Christophe Kerello
2024-02-15 18:56 ` Krzysztof Kozlowski
2024-02-16 8:15 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 07/12] memory: stm32-fmc2-ebi: add runtime PM support Christophe Kerello
2024-02-13 7:59 ` Krzysztof Kozlowski
2024-02-13 13:31 ` Christophe Kerello
2024-02-13 13:33 ` Krzysztof Kozlowski
2024-02-12 17:48 ` [PATCH 08/12] dt-bindings: mtd: st,stm32: add MP25 support Christophe Kerello
2024-02-12 18:38 ` Conor Dooley
2024-02-13 10:57 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 09/12] mtd: rawnand: stm32_fmc2: use dma_get_slave_caps to get DMA max burst Christophe Kerello
2024-02-12 17:48 ` [PATCH 10/12] mtd: rawnand: stm32_fmc2: add a platform data structure Christophe Kerello
2024-02-12 17:48 ` [PATCH 11/12] mtd: rawnand: stm32_fmc2: add MP25 support Christophe Kerello
2024-02-12 17:48 ` [PATCH 12/12] mtd: rawnand: stm32_fmc2: update the driver to support revision 2 Christophe Kerello
2024-02-13 7:34 ` [PATCH 00/12] Add MP25 FMC2 support Krzysztof Kozlowski
2024-02-13 12:09 ` Christophe Kerello
2024-02-14 10:02 ` Krzysztof Kozlowski
2024-02-16 17:59 ` Christophe Kerello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ec4d01-717e-440b-bc54-8652fb68965e@foss.st.com \
--to=christophe.kerello@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®