From: Christophe Kerello <christophe.kerello@foss.st.com>
To: Conor Dooley <conor@kernel.org>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 08/12] dt-bindings: mtd: st,stm32: add MP25 support
Date: Tue, 13 Feb 2024 11:57:27 +0100 [thread overview]
Message-ID: <4ec4a926-fd1c-44e7-990b-4af0e09b9224@foss.st.com> (raw)
In-Reply-To: <20240212-squeak-mortality-5a53a4d1039c@spud>
On 2/12/24 19:38, Conor Dooley wrote:
> On Mon, Feb 12, 2024 at 06:48:18PM +0100, Christophe Kerello wrote:
>> Add 2 new compatible strings to support MP25 SOC.
>> MP25 SOC supports up to 4 chip select.
>
> Again, please explain why the new device is not compatible with the
> existing ones. Also, please explain why two compatibles are required for
> the mp25.
>
Hi Conor,
FMC2 IP supports up to 4 chip select. On MP1 SoC, only 2 of them are
available when on MP25 SoC, the 4 chip select are available.
MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds
revision 2.0 of the FMC2 IP.
I will add this explanation in the commit message.
Regards,
Christophe Kerello.
> Thanks,
> Conor.
>
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
>> ---
>> .../bindings/mtd/st,stm32-fmc2-nand.yaml | 58 ++++++++++++++++++-
>> 1 file changed, 57 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
>> index e72cb5bacaf0..33a753c8877b 100644
>> --- a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
>> @@ -14,10 +14,12 @@ properties:
>> enum:
>> - st,stm32mp15-fmc2
>> - st,stm32mp1-fmc2-nfc
>> + - st,stm32mp25-fmc2
>> + - st,stm32mp25-fmc2-nfc
>>
>> reg:
>> minItems: 6
>> - maxItems: 7
>> + maxItems: 13
>>
>> interrupts:
>> maxItems: 1
>> @@ -92,6 +94,60 @@ allOf:
>> - description: Chip select 1 command
>> - description: Chip select 1 address space
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: st,stm32mp25-fmc2
>> + then:
>> + properties:
>> + reg:
>> + items:
>> + - description: Registers
>> + - description: Chip select 0 data
>> + - description: Chip select 0 command
>> + - description: Chip select 0 address space
>> + - description: Chip select 1 data
>> + - description: Chip select 1 command
>> + - description: Chip select 1 address space
>> + - description: Chip select 2 data
>> + - description: Chip select 2 command
>> + - description: Chip select 2 address space
>> + - description: Chip select 3 data
>> + - description: Chip select 3 command
>> + - description: Chip select 3 address space
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + required:
>> + - clocks
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: st,stm32mp25-fmc2-nfc
>> + then:
>> + properties:
>> + reg:
>> + items:
>> + - description: Chip select 0 data
>> + - description: Chip select 0 command
>> + - description: Chip select 0 address space
>> + - description: Chip select 1 data
>> + - description: Chip select 1 command
>> + - description: Chip select 1 address space
>> + - description: Chip select 2 data
>> + - description: Chip select 2 command
>> + - description: Chip select 2 address space
>> + - description: Chip select 3 data
>> + - description: Chip select 3 command
>> + - description: Chip select 3 address space
>> +
>> required:
>> - compatible
>> - reg
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2024-02-13 10:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:48 [PATCH 00/12] Add MP25 FMC2 support Christophe Kerello
2024-02-12 17:48 ` [PATCH 01/12] dt-bindings: memory-controller: st,stm32: add MP25 support Christophe Kerello
2024-02-12 18:30 ` Conor Dooley
2024-02-13 10:56 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 02/12] dt-bindings: memory-controller: st,stm32: add 'power-domains' property Christophe Kerello
2024-02-12 18:33 ` Conor Dooley
2024-02-13 10:57 ` Christophe Kerello
2024-02-13 11:57 ` Krzysztof Kozlowski
2024-02-13 15:57 ` Christophe Kerello
2024-02-14 10:07 ` Krzysztof Kozlowski
2024-02-12 17:48 ` [PATCH 03/12] memory: stm32-fmc2-ebi: add a platform data structure Christophe Kerello
2024-02-12 17:48 ` [PATCH 04/12] memory: stm32-fmc2-ebi: add MP25 support Christophe Kerello
2024-02-13 7:36 ` Krzysztof Kozlowski
2024-02-13 12:29 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 05/12] memory: stm32-fmc2-ebi: update the driver to support revision 2 Christophe Kerello
2024-02-13 7:46 ` Krzysztof Kozlowski
2024-02-13 12:36 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 06/12] memory: stm32-fmc2-ebi: add RIF support Christophe Kerello
2024-02-13 7:52 ` Krzysztof Kozlowski
2024-02-13 13:15 ` Christophe Kerello
2024-02-14 10:07 ` Krzysztof Kozlowski
2024-02-15 9:00 ` Christophe Kerello
2024-02-15 18:56 ` Krzysztof Kozlowski
2024-02-16 8:15 ` Christophe Kerello
2024-02-12 17:48 ` [PATCH 07/12] memory: stm32-fmc2-ebi: add runtime PM support Christophe Kerello
2024-02-13 7:59 ` Krzysztof Kozlowski
2024-02-13 13:31 ` Christophe Kerello
2024-02-13 13:33 ` Krzysztof Kozlowski
2024-02-12 17:48 ` [PATCH 08/12] dt-bindings: mtd: st,stm32: add MP25 support Christophe Kerello
2024-02-12 18:38 ` Conor Dooley
2024-02-13 10:57 ` Christophe Kerello [this message]
2024-02-12 17:48 ` [PATCH 09/12] mtd: rawnand: stm32_fmc2: use dma_get_slave_caps to get DMA max burst Christophe Kerello
2024-02-12 17:48 ` [PATCH 10/12] mtd: rawnand: stm32_fmc2: add a platform data structure Christophe Kerello
2024-02-12 17:48 ` [PATCH 11/12] mtd: rawnand: stm32_fmc2: add MP25 support Christophe Kerello
2024-02-12 17:48 ` [PATCH 12/12] mtd: rawnand: stm32_fmc2: update the driver to support revision 2 Christophe Kerello
2024-02-13 7:34 ` [PATCH 00/12] Add MP25 FMC2 support Krzysztof Kozlowski
2024-02-13 12:09 ` Christophe Kerello
2024-02-14 10:02 ` Krzysztof Kozlowski
2024-02-16 17:59 ` Christophe Kerello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec4a926-fd1c-44e7-990b-4af0e09b9224@foss.st.com \
--to=christophe.kerello@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®