mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Ulf Hansson <ulfh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-mmc@vger.kernel.org, monish.chunara@oss.qualcomm.com,
	Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform
Date: Mon, 8 Jun 2026 12:44:52 +0200	[thread overview]
Message-ID: <18f5e5a0-de70-4d6a-bc5a-93d402059aff@oss.qualcomm.com> (raw)
In-Reply-To: <3758be2d-4553-40b3-8ae6-bc3e502d0531@oss.qualcomm.com>

On 5/27/26 3:32 PM, Komal Bajaj wrote:
> On 5/25/2026 6:46 PM, Konrad Dybcio wrote:
>> On 5/22/26 8:02 PM, Komal Bajaj wrote:
>>> Add device tree include for the CQ2390M variant of the Shikra
>>> System-on-Module, a compact compute module integrating the Shikra SoC
>>> and PMIC for IoT applications, designed to mount on carrier boards.
>>>
>>>    - shikra-cqm-som.dtsi: Retail SoM with modem (PM4125 and PM8005 PMIC)
>>>
>>> The DTSI includes the common shikra.dtsi, adds PM4125 and PM8005 PMIC
>>> regulator definitions specific to this variant.
>>>
>>> Co-developed-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
>>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
>>> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>>> ---

[...]

>>> +&pm8005_regulators {
>>> +    status = "disabled";
>>> +};
>> ?
> 
> Already there's an ongoing discussion over the thread [1].
> PM8005 regulators are controlled by rpmpd so it's not expected to be enabled here.
> 
> [1]: https://lore.kernel.org/all/20260525093453.edmqryggp5kcqxxy@hu-kotarake-hyd.qualcomm.com/

Right. Downstream, MSM8998 (the other user) binds it to the GFX CPR,
which probably has the benefit lower latency than if it were to go
through RPM (although I was sorta hoping this would be an instance
of cargo cult that we could just rip out..).

If you add /omit-if-no-ref/ above the definition of the pm8005_regulators
node in pm8005.dtsi, does it get correctly skipped (i.e. if you do
dtc -I dtb shikra.dtb -O dts | grep qcom,pm8005-regulators, is is there)?

Konrad

  reply	other threads:[~2026-06-08 10:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 18:02 [PATCH v3 0/5] arm64: dts: qcom: Add initial device tree support for Shikra Komal Bajaj
2026-05-22 18:02 ` [PATCH v3 1/5] dt-bindings: arm: qcom: Document Shikra and its EVK boards Komal Bajaj
2026-05-26 15:45   ` Krzysztof Kozlowski
2026-05-27  7:12     ` Komal Bajaj
2026-05-27  8:55       ` Krzysztof Kozlowski
2026-05-27 14:09         ` Komal Bajaj
2026-05-22 18:02 ` [PATCH v3 2/5] arm64: dts: qcom: Introduce Shikra SoC base dtsi Komal Bajaj
2026-05-22 18:02 ` [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform Komal Bajaj
2026-05-25 13:16   ` Konrad Dybcio
2026-05-27 13:32     ` Komal Bajaj
2026-06-08 10:44       ` Konrad Dybcio [this message]
2026-05-22 18:02 ` [PATCH v3 4/5] arm64: dts: qcom: Add Shikra IQ2390S " Komal Bajaj
2026-05-22 18:02 ` [PATCH v3 5/5] arm64: dts: qcom: Add Shikra EVK boards Komal Bajaj
2026-05-25 13:17   ` Konrad Dybcio
2026-05-25 13:14 ` [PATCH v3 0/5] arm64: dts: qcom: Add initial device tree support for Shikra Konrad Dybcio
2026-05-27 13:51   ` Komal Bajaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18f5e5a0-de70-4d6a-bc5a-93d402059aff@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=monish.chunara@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=ulfh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®