Re: [PATCH v3] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers

[Chintan Patel <chintanlike@gmail.com>]

On 3/6/26 09:40, Doug Anderson wrote:
> Hi,
> 
> On Wed, Mar 4, 2026 at 8:49 PM Chintan Patel <chintanlike@gmail.com> wrote:
>>
>> Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and
>> mipi_dsi_msleep().
>>
>> Switch DCS command sequences to the multi context API and
>> accumulate errors via struct mipi_dsi_multi_context. Replace
>> open-coded error handling with the multi helpers and convert
>> nt36672a_send_cmds() and power sequencing accordingly.
>>
>> This patch is intended to functionally be a no-op, though there is one
>> slight change. Previously a failure in regulator_bulk_disable() would
>> have caused nt36672a_panel_unprepare() to return an error. Now it
>> won't. No other errors in nt36672a_panel_unprepare() were propagated,
>> so this makes things consistent.
>>
>> Signed-off-by: Chintan Patel <chintanlike@gmail.com>
>> ---
>> Changes in v3:
>> - Keep local ret variable in nt36672a_panel_power_off() to preserve error code in logging.
>> - Change mipi_dsi_msleep() back to regular msleep(60) in power-down sequence to preserve behavior.
>> - Reset dsi_ctx.accum_err before set_display_off_multi() and before power-down to preserve original error-tolerant shutdown behavior.
>>
>> Changes in v2:
>> - Address alignment feedback from Doug.
>> - Restore original power-down ordering.
>> - Drop return value from nt36672a_panel_power_off().
>> - Consolidate error handling around dsi_ctx.accum_err.
>>
>>   .../gpu/drm/panel/panel-novatek-nt36672a.c    | 94 ++++++-------------
>>   1 file changed, 30 insertions(+), 64 deletions(-)
> 
> Looks good to me now. I'll plan to apply in ~1 week if there is no
> further feedback.
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> 
> As per my response in v1 [1], someone could still do additional
> cleanup to move away from the table-based initialization, but it
> doesn't make sense to block this patch on that. :-)
> 

Agree - I have plan to address as separate patch.

> [1] https://lore.kernel.org/r/CAD=FV=WtjW5WWmjeb2zwF2PjiJeZv1jZS_UKZ0bT1658=CkwVA@mail.gmail.com
> 
> -Doug