From: Markus Elfring <Markus.Elfring@web.de>
To: Wei Yongjun <weiyongjun1@huawei.com>, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi_bind()
Date: Tue, 28 Apr 2020 18:15:26 +0200 [thread overview]
Message-ID: <1900157b-39fe-e6fe-6fe7-26053a32f507@web.de> (raw)
> In case of error, the function of_drm_find_bridge() returns NULL pointer
> not ERR_PTR().
Such information is helpful.
> The IS_ERR() test in the return value check should be
> replaced with NULL test.
* Would you like to convert this description into an imperative wording?
* Please fix the patch subject according to a function name.
* How do you think about to add the tag “Fixes” to the commit message
because of an adjustment for the error detection?
Regards,
Markus
reply other threads:[~2020-04-28 16:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1900157b-39fe-e6fe-6fe7-26053a32f507@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome