* Re: [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi_bind()
@ 2020-04-28 16:15 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-28 16:15 UTC (permalink / raw)
To: Wei Yongjun, dri-devel
Cc: kernel-janitors, linux-kernel, Daniel Vetter, David Airlie,
Linus Walleij
> In case of error, the function of_drm_find_bridge() returns NULL pointer
> not ERR_PTR().
Such information is helpful.
> The IS_ERR() test in the return value check should be
> replaced with NULL test.
* Would you like to convert this description into an imperative wording?
* Please fix the patch subject according to a function name.
* How do you think about to add the tag “Fixes” to the commit message
because of an adjustment for the error detection?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-28 16:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 16:15 [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi_bind() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome