* [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure
@ 2021-04-07 15:45 Krzysztof Kozlowski
2021-04-07 15:56 ` Lukasz Luba
2021-04-13 14:58 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-07 15:45 UTC (permalink / raw)
To: Lukasz Luba, Krzysztof Kozlowski, linux-pm, linux-samsung-soc,
linux-kernel, linux-arm-kernel
clk_set_parent() can fail and ignoring such case could lead to invalid
clock setup for given frequency.
Addresses-Coverity: Unchecked return value
Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/memory/samsung/exynos5422-dmc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 56f6e65d40cd..9c8318923ed0 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -1293,7 +1293,9 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc)
dmc->curr_volt = target_volt;
- clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll);
+ ret = clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll);
+ if (ret)
+ return ret;
clk_prepare_enable(dmc->fout_bpll);
clk_prepare_enable(dmc->mout_bpll);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure
2021-04-07 15:45 [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure Krzysztof Kozlowski
@ 2021-04-07 15:56 ` Lukasz Luba
2021-04-13 14:58 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Luba @ 2021-04-07 15:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-pm, linux-samsung-soc, linux-kernel, linux-arm-kernel
Hi Krzysztof,
On 4/7/21 4:45 PM, Krzysztof Kozlowski wrote:
> clk_set_parent() can fail and ignoring such case could lead to invalid
> clock setup for given frequency.
>
> Addresses-Coverity: Unchecked return value
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 56f6e65d40cd..9c8318923ed0 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -1293,7 +1293,9 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc)
>
> dmc->curr_volt = target_volt;
>
> - clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll);
> + ret = clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll);
> + if (ret)
> + return ret;
>
> clk_prepare_enable(dmc->fout_bpll);
> clk_prepare_enable(dmc->mout_bpll);
>
Thanks for running these tests and for the patch.
I've checked how many many places this function is used in the kernel
and return is ignored - in a lot of places...
This patch LGTM.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure
2021-04-07 15:45 [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure Krzysztof Kozlowski
2021-04-07 15:56 ` Lukasz Luba
@ 2021-04-13 14:58 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-13 14:58 UTC (permalink / raw)
To: linux-pm, linux-kernel, linux-samsung-soc, Krzysztof Kozlowski,
Lukasz Luba, linux-arm-kernel
On Wed, 7 Apr 2021 17:45:35 +0200, Krzysztof Kozlowski wrote:
> clk_set_parent() can fail and ignoring such case could lead to invalid
> clock setup for given frequency.
Applied, thanks!
[1/1] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure
commit: 132c17c3ff878c7beaba51bdd275d5cc654c0e33
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-13 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 15:45 [PATCH] memory: samsung: exynos5422-dmc: handle clk_set_parent() failure Krzysztof Kozlowski
2021-04-07 15:56 ` Lukasz Luba
2021-04-13 14:58 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®