mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Do not enable by default during compile testing
Date: Fri, 04 Apr 2025 15:08:46 +0200	[thread overview]
Message-ID: <191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com> (raw)
In-Reply-To: <05d96c93-f9a8-42ea-9c11-2d38a7dffff7@linaro.org>

On Fri, Apr 4, 2025, at 14:59, Krzysztof Kozlowski wrote:
> On 04/04/2025 14:57, Krzysztof Kozlowski wrote:
>> On 04/04/2025 14:49, Guenter Roeck wrote:
>>> On 4/4/25 05:39, Krzysztof Kozlowski wrote:
>>>> Enabling the compile test should not cause automatic enabling of all
>>>> drivers.
>>>>
>>>
>>> Sorry, I seem to be missing something.
>>>
>>> Isn't that what COMPILE_TEST is all about, that it enables everything ?
>> 
>> No. Compile test *allows* to compile test, but it does not mean you want
>> immediately compile everything. allyesconfig is for everything. Maybe
>> you want to compile some subset of drivers.
>> 
>> BTW, I am aligning with the most frequent pattern (quickly judging), so
>> of course I also accept argument that we should revert that other
>> pattern and use "default y" everywhere.
>
> I also dug out old recommendation from Arnd (so I am not making this
> stuff up):

Right, I agree with your patch here: COMPILE_TEST=y should make a
lot more options visible but not generally enable those.

Note that COMPILE_TEST=y also turns *off* some other options in
order to speed up the (allmodconfig) build process and avoid
some options that are unhelp for finding build issues:

lib/Kconfig.kasan-config KASAN_STACK
lib/Kconfig.kasan:      bool "Stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST
security/Kconfig.hardening-config GCC_PLUGIN_STACKLEAK_VERBOSE
security/Kconfig.hardening-     bool "Report stack depth analysis instrumentation" if EXPERT
security/Kconfig.hardening-     depends on GCC_PLUGIN_STACKLEAK
security/Kconfig.hardening:     depends on !COMPILE_TEST        # too noisy
kernel/gcov/Kconfig-config GCOV_PROFILE_ALL
kernel/gcov/Kconfig-    bool "Profile entire Kernel"
kernel/gcov/Kconfig:    depends on !COMPILE_TEST

     Arnd

  reply	other threads:[~2025-04-04 13:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 12:39 Krzysztof Kozlowski
2025-04-04 12:49 ` Guenter Roeck
2025-04-04 12:57   ` Krzysztof Kozlowski
2025-04-04 12:59     ` Krzysztof Kozlowski
2025-04-04 13:08       ` Arnd Bergmann [this message]
2025-04-04 15:05     ` Guenter Roeck
2025-04-04 15:05 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®