From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Do not enable by default during compile testing
Date: Fri, 4 Apr 2025 05:49:50 -0700 [thread overview]
Message-ID: <8b6ede05-281a-4fb1-bcdc-457e6f2610ff@roeck-us.net> (raw)
In-Reply-To: <20250404123941.362620-1-krzysztof.kozlowski@linaro.org>
On 4/4/25 05:39, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers.
>
Sorry, I seem to be missing something.
Isn't that what COMPILE_TEST is all about, that it enables everything ?
Guenter
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/watchdog/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 0d8d37f712e8..1d29e5f4f40c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1001,7 +1001,7 @@ config STM32_WATCHDOG
> tristate "STM32 Independent WatchDoG (IWDG) support"
> depends on ARCH_STM32 || COMPILE_TEST
> select WATCHDOG_CORE
> - default y
> + default ARCH_STM32
> help
> Say Y here to include support for the watchdog timer
> in stm32 SoCs.
> @@ -1869,7 +1869,7 @@ config OCTEON_WDT
> config MARVELL_GTI_WDT
> tristate "Marvell GTI Watchdog driver"
> depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> - default y
> + default ARCH_THUNDER
> select WATCHDOG_CORE
> help
> Marvell GTI hardware supports watchdog timer. First timeout
> @@ -2035,7 +2035,7 @@ config 8xxx_WDT
> config PIKA_WDT
> tristate "PIKA FPGA Watchdog"
> depends on WARP || (PPC64 && COMPILE_TEST)
> - default y
> + default WARP
> help
> This enables the watchdog in the PIKA FPGA. Currently used on
> the Warp platform.
next prev parent reply other threads:[~2025-04-04 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 12:39 Krzysztof Kozlowski
2025-04-04 12:49 ` Guenter Roeck [this message]
2025-04-04 12:57 ` Krzysztof Kozlowski
2025-04-04 12:59 ` Krzysztof Kozlowski
2025-04-04 13:08 ` Arnd Bergmann
2025-04-04 15:05 ` Guenter Roeck
2025-04-04 15:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6ede05-281a-4fb1-bcdc-457e6f2610ff@roeck-us.net \
--to=linux@roeck-us.net \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®