* [PATCH RESEND v2 1/4] arm64: dts: mediatek: mt8183: Fix race condition of pinctrl
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
@ 2024-11-05 3:08 ` Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 2/4] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver Hsin-Te Yuan
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hsin-Te Yuan @ 2024-11-05 3:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Enric Balletbo i Serra, Hsin-Yi Wang,
Benjamin Tissoires, Hans de Goede
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Hsin-Te Yuan
Some mt8183 devices use second source touchscreen/trackpad and share the
same pinctrl property with the original touchscreen/trackpad. Currently,
multiple touchscreen/trackpad drivers might probe simultaneously,
causing a race condition of getting the same pin.
Move the pinctrl property to the i2c node to workaround this issue.
Fixes: dd6e3b06214f ("arm64: dts: mt8183: Add kukui-jacuzzi-burnet board")
Fixes: 52e84f233459 ("arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board")
Fixes: 6cd7fdc8c530 ("arm64: dts: mt8183: Add kukui-jacuzzi-fennel board")
Fixes: 124d64392de2 ("arm64: dts: mt8183: Add kukui-jacuzzi-juniper board")
Fixes: f006bcf1c972 ("arm64: dts: mt8183: Add kukui-jacuzzi-willow board")
Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board")
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 --
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 2 --
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 2 --
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 2 --
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 2 --
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 ---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++-------
12 files changed, 3 insertions(+), 35 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts
index 19c1e2bee494c98c0db87308494713a26e304cd2..32ec6fd30fdb7449e9e606f69d16556bcdecc369 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts
@@ -21,8 +21,6 @@ &i2c0 {
touchscreen@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
post-power-on-delay-ms = <200>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
index f34964afe39b5353de7b17e82d14d1fba88551ab..b75ab2d33550808196f2d1d4bf0d34ccb713a07a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
@@ -23,9 +23,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
index 0b45aee2e29953b6117b462034a00dff2596b9ff..ebe6e161354c414d91859494ec9295db75a3baf9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
@@ -19,8 +19,6 @@ &touchscreen {
compatible = "hid-over-i2c";
reg = <0x10>;
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
post-power-on-delay-ms = <10>;
hid-descr-addr = <0x0001>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
index 72852b7600383972d98d9b0edd40b6e99e34a85b..2dc64cc539f815b9848b8243e5b487f22d605a6d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
@@ -32,8 +32,6 @@ &touchscreen {
compatible = "hid-over-i2c";
reg = <0x10>;
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
post-power-on-delay-ms = <10>;
hid-descr-addr = <0x0001>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
index 757d0afd14fb064fc1de4608e65eb1a561c4dfa6..53e996f9c605dc36df03d4b0051a91e19fefb38d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
@@ -19,8 +19,6 @@ &touchscreen {
compatible = "hid-over-i2c";
reg = <0x10>;
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
post-power-on-delay-ms = <10>;
hid-descr-addr = <0x0001>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
index 6641b087e7c5f3a957e43ac985137dfd84ac7878..d7db621383c6b823af08ca07e0794758d062e211 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
@@ -19,8 +19,6 @@ &touchscreen {
compatible = "hid-over-i2c";
reg = <0x10>;
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
post-power-on-delay-ms = <10>;
hid-descr-addr = <0x0001>;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
index bbe6c338f465ee7c11bfbfc30767bdb142706480..e5b51b27980ae90a8f1099f71a891bb0562a375a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
@@ -16,9 +16,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi
index 078bc765646f57fd8c55e97325893ab50e4dac51..a96c64a9251044b2c1ba4289467b411e6c744abe 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi
@@ -12,9 +12,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts
index 8ce9568fee95a6faba0c238f6c43f43948c26d9b..2c740b3e5d3d91980ed89e07a6be70ff51906145 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts
@@ -25,9 +25,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
index cce326aec1aa594deb6f5b14340d3552d110b160..bce368fcc884008086c091a29e3f69e541215ee5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
@@ -38,9 +38,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi
index 76d33540166f900c99c419c4f97ca0a56cf658f5..9b1600d5c4c1247c97fd59aa7603eaa835420117 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi
@@ -12,9 +12,6 @@ trackpad@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 783c333107bcbf7368398feae0a29e5f0ee50c19..65f70627f2dcc4af832b8a08f7cdce354c800fae 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -100,14 +100,13 @@ &dsi_out {
&i2c0 {
status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_pins>;
touchscreen: touchscreen@10 {
compatible = "elan,ekth3500";
reg = <0x10>;
- pinctrl-names = "default";
- pinctrl-0 = <&touchscreen_pins>;
-
interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
reset-gpios = <&pio 156 GPIO_ACTIVE_LOW>;
@@ -116,7 +115,7 @@ touchscreen: touchscreen@10 {
&i2c2 {
pinctrl-names = "default";
- pinctrl-0 = <&i2c2_pins>;
+ pinctrl-0 = <&i2c2_pins>, <&trackpad_pins>;
status = "okay";
clock-frequency = <400000>;
@@ -124,9 +123,6 @@ trackpad@15 {
compatible = "elan,ekth3000";
reg = <0x15>;
- pinctrl-names = "default";
- pinctrl-0 = <&trackpad_pins>;
-
interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
wakeup-source;
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH RESEND v2 2/4] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 1/4] arm64: dts: mediatek: mt8183: Fix race condition of pinctrl Hsin-Te Yuan
@ 2024-11-05 3:08 ` Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 3/4] arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen Hsin-Te Yuan
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hsin-Te Yuan @ 2024-11-05 3:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Enric Balletbo i Serra, Hsin-Yi Wang,
Benjamin Tissoires, Hans de Goede
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Hsin-Te Yuan
After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to
i2c-hid-of"), the i2c-hid-of driver used by some mt8183 devices resets
the touchscreen without having enough post-reset delay. This makes those
touchscreen fail to get probed.
Switch to Elan touchscreen driver, which has enough post-reset delay.
Fixes: 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of")
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 10 +++-------
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 9 ++-------
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 9 ++-------
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 9 ++-------
4 files changed, 9 insertions(+), 28 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
index ebe6e161354c414d91859494ec9295db75a3baf9..b98a3530511e576347a4ed291d37d45dd42fec97 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts
@@ -14,14 +14,10 @@ / {
};
&touchscreen {
- status = "okay";
+ compatible = "elan,ekth6a12nay";
- compatible = "hid-over-i2c";
- reg = <0x10>;
- interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
-
- post-power-on-delay-ms = <10>;
- hid-descr-addr = <0x0001>;
+ vcc33-supply = <&pp3300_alw>;
+ vccio-supply = <&pp1800_alw>;
};
&qca_wifi {
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
index 2dc64cc539f815b9848b8243e5b487f22d605a6d..9fb329626a82034e44fb5fbd2d0ad9675c0a5afa 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
@@ -27,14 +27,9 @@ &cros_ec_pwm {
};
&touchscreen {
- status = "okay";
-
- compatible = "hid-over-i2c";
- reg = <0x10>;
- interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
+ compatible = "elan,ekth6a12nay";
- post-power-on-delay-ms = <10>;
- hid-descr-addr = <0x0001>;
+ vcc33-supply = <&pp3300_alw>;
};
&qca_wifi {
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
index 53e996f9c605dc36df03d4b0051a91e19fefb38d..6d547361fc4f9d2ab1f9b048af443495c9bed323 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
@@ -14,14 +14,9 @@ / {
};
&touchscreen {
- status = "okay";
+ compatible = "elan,ekth6a12nay";
- compatible = "hid-over-i2c";
- reg = <0x10>;
- interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
-
- post-power-on-delay-ms = <10>;
- hid-descr-addr = <0x0001>;
+ vcc33-supply = <&pp3300_alw>;
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
index d7db621383c6b823af08ca07e0794758d062e211..39ab09ce28aa2ed4335d5279a965f23a8458688e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
@@ -14,14 +14,9 @@ / {
};
&touchscreen {
- status = "okay";
+ compatible = "elan,ekth6a12nay";
- compatible = "hid-over-i2c";
- reg = <0x10>;
- interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
-
- post-power-on-delay-ms = <10>;
- hid-descr-addr = <0x0001>;
+ vcc33-supply = <&pp3300_alw>;
};
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH RESEND v2 3/4] arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 1/4] arm64: dts: mediatek: mt8183: Fix race condition of pinctrl Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 2/4] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver Hsin-Te Yuan
@ 2024-11-05 3:08 ` Hsin-Te Yuan
2024-11-05 3:08 ` [PATCH RESEND v2 4/4] arm64: dts: mediatek: mt8183: willow: " Hsin-Te Yuan
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hsin-Te Yuan @ 2024-11-05 3:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Enric Balletbo i Serra, Hsin-Yi Wang,
Benjamin Tissoires, Hans de Goede
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Hsin-Te Yuan
Some kenzo devices use second source touchscreen.
Fixes: 0a9cefe21aec ("arm64: dts: mt8183: Add kukui-jacuzzi-kenzo board")
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
index e8241587949b2bc238ffa85f8fa6b6ca78b1d6f5..813e6bf65b62ee6742e52133f9adf7e83a6078c5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
@@ -12,3 +12,15 @@ / {
chassis-type = "laptop";
compatible = "google,juniper-sku17", "google,juniper", "mediatek,mt8183";
};
+
+&i2c0 {
+ touchscreen@40 {
+ compatible = "hid-over-i2c";
+ reg = <0x40>;
+
+ interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
+
+ post-power-on-delay-ms = <70>;
+ hid-descr-addr = <0x0001>;
+ };
+};
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH RESEND v2 4/4] arm64: dts: mediatek: mt8183: willow: Support second source touchscreen
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
` (2 preceding siblings ...)
2024-11-05 3:08 ` [PATCH RESEND v2 3/4] arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen Hsin-Te Yuan
@ 2024-11-05 3:08 ` Hsin-Te Yuan
2024-11-05 13:11 ` [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Rob Herring (Arm)
2024-11-15 9:37 ` AngeloGioacchino Del Regno
5 siblings, 0 replies; 7+ messages in thread
From: Hsin-Te Yuan @ 2024-11-05 3:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Enric Balletbo i Serra, Hsin-Yi Wang,
Benjamin Tissoires, Hans de Goede
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Hsin-Te Yuan
Some willow devices use second source touchscreen.
Fixes: f006bcf1c972 ("arm64: dts: mt8183: Add kukui-jacuzzi-willow board")
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
index 813e6bf65b62ee6742e52133f9adf7e83a6078c5..e8241587949b2bc238ffa85f8fa6b6ca78b1d6f5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dts
@@ -12,15 +12,3 @@ / {
chassis-type = "laptop";
compatible = "google,juniper-sku17", "google,juniper", "mediatek,mt8183";
};
-
-&i2c0 {
- touchscreen@40 {
- compatible = "hid-over-i2c";
- reg = <0x40>;
-
- interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>;
-
- post-power-on-delay-ms = <70>;
- hid-descr-addr = <0x0001>;
- };
-};
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
` (3 preceding siblings ...)
2024-11-05 3:08 ` [PATCH RESEND v2 4/4] arm64: dts: mediatek: mt8183: willow: " Hsin-Te Yuan
@ 2024-11-05 13:11 ` Rob Herring (Arm)
2024-11-15 9:37 ` AngeloGioacchino Del Regno
5 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2024-11-05 13:11 UTC (permalink / raw)
To: Hsin-Te Yuan
Cc: linux-arm-kernel, devicetree, Hans de Goede, linux-mediatek,
linux-kernel, Conor Dooley, Enric Balletbo i Serra,
Matthias Brugger, Benjamin Tissoires, AngeloGioacchino Del Regno,
Hsin-Yi Wang, Krzysztof Kozlowski
On Tue, 05 Nov 2024 03:08:10 +0000, Hsin-Te Yuan wrote:
> After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to
> i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having
> proper post-reset delay on OF platform. From the commit message of that
> commit, not to decribe poset-reset delay in device tree is intended.
> Instead, describing the delay in platform data and changing to use
> specialized driver is more preferable solution.
>
> Also workaround the race condition of pinctrl used by touchscreen and
> trackpad in this series to avoid merge conflict.
>
> Adding other second source touchscreen used by some mt8183 devices in
> this series since this should be based on the workaround of pinctrl
> issue.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> Changes in v2:
> - Add second source touchscreen patches since they should based on the
> first patch of this series.
> - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb7550037@chromium.org
>
> ---
> Hsin-Te Yuan (4):
> arm64: dts: mediatek: mt8183: Fix race condition of pinctrl
> arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver
> arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen
> arm64: dts: mediatek: mt8183: willow: Support second source touchscreen
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 --
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 12 +++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 11 ++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 11 ++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 11 ++---------
> .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 ---
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ---
> .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++-------
> 12 files changed, 12 insertions(+), 63 deletions(-)
> ---
> base-commit: eca631b8fe808748d7585059c4307005ca5c5820
> change-id: 20241018-post-reset-ac66b0351613
>
> Best regards,
> --
> Hsin-Te Yuan <yuanhsinte@chromium.org>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y mediatek/mt8183-kukui-jacuzzi-burnet.dtb mediatek/mt8183-kukui-jacuzzi-cozmo.dtb mediatek/mt8183-kukui-jacuzzi-damu.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb mediatek/mt8183-kukui-jacuzzi-kenzo.dtb mediatek/mt8183-kukui-jacuzzi-pico.dtb mediatek/mt8183-kukui-jacuzzi-pico6.dtb' for 20241105-post-reset-v2-0-c1dc94b65017@chromium.org:
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb: dsi@14014000: Unevaluated properties are not allowed ('ports' was unexpected)
from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dsi.yaml#
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver
2024-11-05 3:08 [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Hsin-Te Yuan
` (4 preceding siblings ...)
2024-11-05 13:11 ` [PATCH RESEND v2 0/4] Using i2c-hid-of-elan driver instead of i2c-hid-of driver Rob Herring (Arm)
@ 2024-11-15 9:37 ` AngeloGioacchino Del Regno
5 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-11-15 9:37 UTC (permalink / raw)
To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Enric Balletbo i Serra, Hsin-Yi Wang,
Benjamin Tissoires, Hans de Goede
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
Il 05/11/24 04:08, Hsin-Te Yuan ha scritto:
> After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to
> i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having
> proper post-reset delay on OF platform. From the commit message of that
> commit, not to decribe poset-reset delay in device tree is intended.
> Instead, describing the delay in platform data and changing to use
> specialized driver is more preferable solution.
>
> Also workaround the race condition of pinctrl used by touchscreen and
> trackpad in this series to avoid merge conflict.
>
> Adding other second source touchscreen used by some mt8183 devices in
> this series since this should be based on the workaround of pinctrl
> issue.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
The switch to i2c-hid-of-elan is okay, but the pinctrl hack is not necessary
anymore, as it does get resolved with the hwprober from Chen-Yu
https://lore.kernel.org/all/20241106093335.1582205-1-wenst@chromium.org/
Please redo the second source TS addition based on that series instead.
Thanks,
Angelo
> ---
> Changes in v2:
> - Add second source touchscreen patches since they should based on the
> first patch of this series.
> - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb7550037@chromium.org
>
> ---
> Hsin-Te Yuan (4):
> arm64: dts: mediatek: mt8183: Fix race condition of pinctrl
> arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver
> arm64: dts: mediatek: mt8183: kenzo: Support second source touchscreen
> arm64: dts: mediatek: mt8183: willow: Support second source touchscreen
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 --
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 12 +++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 11 ++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 11 ++---------
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 11 ++---------
> .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 ---
> .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ---
> .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++-------
> 12 files changed, 12 insertions(+), 63 deletions(-)
> ---
> base-commit: eca631b8fe808748d7585059c4307005ca5c5820
> change-id: 20241018-post-reset-ac66b0351613
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread