From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Markus Reichl <m.reichl@fivetechno.de>,
Anand Moon <linux.amoon@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler
Date: Thu, 22 Oct 2015 17:51:17 +0200 [thread overview]
Message-ID: <19278822.W8IRxl9izA@diego> (raw)
In-Reply-To: <CAD=FV=VZJ9Tc4G-Xiw60DmfC4izU_6dVwwa0N0ePM0eaJfcqkg@mail.gmail.com>
Am Donnerstag, 22. Oktober 2015, 08:34:38 schrieb Doug Anderson:
> Note that personally I would only choose the "highest" priority as an
> absolute last resort. Leaving a little extra slack in there means
> that when the next person comes up with a really good reason to run
> before you do that they can do it without changing your code.
just to reiterate, restart-handlers are generally not meant as "things to do
before restart", but "are supposed to restart the system, nothing else" [0].
Just in this case there hasn't been a better solution found for the needed
reset even in emergency-reboots ... but this misappropriation of restart-
handlers should not spread into further realms, so there shouldn't be a "next
person" ;-) .
[0] http://permalink.gmane.org/gmane.linux.kernel/1968815
next prev parent reply other threads:[~2015-10-22 15:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 15:15 Javier Martinez Canillas
2015-10-22 0:36 ` Krzysztof Kozlowski
2015-10-22 1:20 ` Javier Martinez Canillas
2015-10-22 1:43 ` Krzysztof Kozlowski
2015-10-22 2:52 ` Javier Martinez Canillas
2015-10-22 4:14 ` Alim Akhtar
2015-10-22 10:07 ` Marek Szyprowski
2015-10-22 11:02 ` Javier Martinez Canillas
2015-10-22 5:03 ` Anand Moon
2015-10-22 8:36 ` Javier Martinez Canillas
2015-10-22 9:42 ` Anand Moon
2015-10-22 15:34 ` Doug Anderson
2015-10-22 15:51 ` Heiko Stübner [this message]
2015-10-22 16:07 ` Javier Martinez Canillas
2015-10-22 17:33 ` Doug Anderson
2015-10-22 17:53 ` Javier Martinez Canillas
2015-10-24 4:55 ` Alim Akhtar
2015-10-27 10:10 ` Ulf Hansson
2015-10-28 11:02 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19278822.W8IRxl9izA@diego \
--to=heiko@sntech.de \
--cc=acourbot@nvidia.com \
--cc=alim.akhtar@samsung.com \
--cc=dianders@chromium.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®