From: "Rafael J. Wysocki" <rafael@kernel.org>
To: chrome-platform@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>
Subject: [PATCH v1 2/6] platform/chrome: chromeos_tbmc: Drop wakeup source on remove
Date: Wed, 04 Mar 2026 19:43:05 +0100 [thread overview]
Message-ID: <1931894.atdPhlSkOF@rafael.j.wysocki> (raw)
In-Reply-To: <2274474.Mh6RI2rZIc@rafael.j.wysocki>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
The wakeup source added by device_init_wakeup() in chromeos_tbmc_add()
needs to be dropped during driver removal, so add a .remove() callback
to the driver for this purpose.
Fixes: 0144c00ed86b (platform/chrome: chromeos_tbmc: Report wake events)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/platform/chrome/chromeos_tbmc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/chrome/chromeos_tbmc.c
index d1cf8f3463ce..e248567c0a18 100644
--- a/drivers/platform/chrome/chromeos_tbmc.c
+++ b/drivers/platform/chrome/chromeos_tbmc.c
@@ -95,6 +95,11 @@ static int chromeos_tbmc_add(struct acpi_device *adev)
return 0;
}
+static void chromeos_tbmc_remove(struct acpi_device *adev)
+{
+ device_init_wakeup(&adev->dev, false);
+}
+
static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = {
{ ACPI_DRV_NAME, 0 },
{ }
@@ -110,6 +115,7 @@ static struct acpi_driver chromeos_tbmc_driver = {
.ids = chromeos_tbmc_acpi_device_ids,
.ops = {
.add = chromeos_tbmc_add,
+ .remove = chromeos_tbmc_remove,
.notify = chromeos_tbmc_notify,
},
.drv.pm = &chromeos_tbmc_pm_ops,
--
2.51.0
next prev parent reply other threads:[~2026-03-04 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:41 [PATCH v1 0/6] platform/chrome: Bind drivers to platform devices instead of ACPI ones Rafael J. Wysocki
2026-03-04 18:42 ` [PATCH v1 1/6] platform/chrome: Convert ChromeOS privacy-screen driver to platform Rafael J. Wysocki
2026-03-04 18:43 ` Rafael J. Wysocki [this message]
2026-03-05 15:29 ` [PATCH v1 2/6] platform/chrome: chromeos_tbmc: Drop wakeup source on remove Tzung-Bi Shih
2026-03-05 15:30 ` Rafael J. Wysocki
2026-03-04 18:43 ` [PATCH v1 3/6] platform/chrome: chromeos_tbmc: Register ACPI notify handler Rafael J. Wysocki
2026-03-04 18:44 ` [PATCH v1 4/6] platform/chrome: chromeos_tbmc: Convert to a platform driver Rafael J. Wysocki
2026-03-05 15:29 ` Tzung-Bi Shih
2026-03-05 15:34 ` Rafael J. Wysocki
2026-03-05 15:50 ` Tzung-Bi Shih
2026-03-05 15:52 ` Rafael J. Wysocki
2026-03-04 18:45 ` [PATCH v1 5/6] platform/chrome: wilco_ec: event: Register ACPI notify handler Rafael J. Wysocki
2026-03-04 18:45 ` [PATCH v1 6/6] platform/chrome: wilco_ec: event: Convert to a platform driver Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1931894.atdPhlSkOF@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=eballetbo@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravisadineni@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®