From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: chrome-platform@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>
Subject: Re: [PATCH v1 4/6] platform/chrome: chromeos_tbmc: Convert to a platform driver
Date: Thu, 5 Mar 2026 23:29:37 +0800 [thread overview]
Message-ID: <aamgGkgfFh-cQNfF@tzungbi-laptop> (raw)
In-Reply-To: <2553054.jE0xQCEvom@rafael.j.wysocki>
On Wed, Mar 04, 2026 at 07:44:26PM +0100, Rafael J. Wysocki wrote:
> static void chromeos_tbmc_notify(acpi_handle handle, u32 event, void *data)
> {
> - struct acpi_device *adev = data;
> + struct device *dev = data;
> + struct acpi_device *adev = ACPI_COMPANION(dev);
>
> acpi_pm_wakeup_event(&adev->dev);
^^^^^^^^^^
If I understand it correctly, I think this should also be changed to `dev`?
next prev parent reply other threads:[~2026-03-05 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:41 [PATCH v1 0/6] platform/chrome: Bind drivers to platform devices instead of ACPI ones Rafael J. Wysocki
2026-03-04 18:42 ` [PATCH v1 1/6] platform/chrome: Convert ChromeOS privacy-screen driver to platform Rafael J. Wysocki
2026-03-04 18:43 ` [PATCH v1 2/6] platform/chrome: chromeos_tbmc: Drop wakeup source on remove Rafael J. Wysocki
2026-03-05 15:29 ` Tzung-Bi Shih
2026-03-05 15:30 ` Rafael J. Wysocki
2026-03-04 18:43 ` [PATCH v1 3/6] platform/chrome: chromeos_tbmc: Register ACPI notify handler Rafael J. Wysocki
2026-03-04 18:44 ` [PATCH v1 4/6] platform/chrome: chromeos_tbmc: Convert to a platform driver Rafael J. Wysocki
2026-03-05 15:29 ` Tzung-Bi Shih [this message]
2026-03-05 15:34 ` Rafael J. Wysocki
2026-03-05 15:50 ` Tzung-Bi Shih
2026-03-05 15:52 ` Rafael J. Wysocki
2026-03-04 18:45 ` [PATCH v1 5/6] platform/chrome: wilco_ec: event: Register ACPI notify handler Rafael J. Wysocki
2026-03-04 18:45 ` [PATCH v1 6/6] platform/chrome: wilco_ec: event: Convert to a platform driver Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamgGkgfFh-cQNfF@tzungbi-laptop \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=eballetbo@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ravisadineni@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®