From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Tuo Li <islituo@gmail.com>
Cc: song@kernel.org, yukuai@fnnas.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] md/raid5: fix possible null-pointer dereferences in raid5_store_group_thread_cnt()
Date: Fri, 26 Dec 2025 12:09:57 +0500 [thread overview]
Message-ID: <19395340-acad-4e2f-938f-874c92b209bc@molgen.mpg.de> (raw)
In-Reply-To: <20251225130326.67780-1-islituo@gmail.com>
Dear Tuo,
Thank you for your patch.
Am 25.12.25 um 18:03 schrieb Tuo Li:
> The variable mddev->private is first assigned to conf and then checked:
>
> conf = mddev->private;
> if (!conf) ...
Should you resend, please align conf` and `if`.
> If conf is NULL, then mddev->private is also NULL. In this case,
> null-pointer dereferences can occur when calling raid5_quiesce():
>
> raid5_quiesce(mddev, true);
> raid5_quiesce(mddev, false);
>
> since mddev->private is assigned to conf again in raid5_quiesce(), and conf
> is dereferenced in several places, for example:
>
> conf->quiesce = 0;
> wake_up(&conf->wait_for_quiescent);
>
> To fix this issue, the function should unlock mddev and return before
> invoking raid5_quiesce() when conf is NULL, following the existing pattern
> in raid5_change_consistency_policy().
>
> Fixes: fa1944bbe622 ("md/raid5: Wait sync io to finish before changing group cnt")
> Signed-off-by: Tuo Li <islituo@gmail.com>
> ---
> v2:
> * Move the NULL check and early return ahead of the first call to
> raid5_quiesce().
> Thanks to Yu Kuai for helpful advice.
> ---
> drivers/md/raid5.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index e57ce3295292..8dc98f545969 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -7187,12 +7187,14 @@ raid5_store_group_thread_cnt(struct mddev *mddev, const char *page, size_t len)
> err = mddev_suspend_and_lock(mddev);
> if (err)
> return err;
> + conf = mddev->private;
> + if (!conf) {
> + mddev_unlock_and_resume(mddev);
> + return -ENODEV;
> + }
> raid5_quiesce(mddev, true);
>
> - conf = mddev->private;
> - if (!conf)
> - err = -ENODEV;
> - else if (new != conf->worker_cnt_per_group) {
> + if (new != conf->worker_cnt_per_group) {
> old_groups = conf->worker_groups;
> if (old_groups)
> flush_workqueue(raid5_wq);
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
next prev parent reply other threads:[~2025-12-26 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 13:03 Tuo Li
2025-12-26 2:19 ` Xiao Ni
2025-12-26 7:09 ` Paul Menzel [this message]
2025-12-27 1:52 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19395340-acad-4e2f-938f-874c92b209bc@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=islituo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®