From: "Yu Kuai" <yukuai@fnnas.com>
To: "Tuo Li" <islituo@gmail.com>, <song@kernel.org>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yukuai@fnnas.com>
Subject: Re: [PATCH v2] md/raid5: fix possible null-pointer dereferences in raid5_store_group_thread_cnt()
Date: Sat, 27 Dec 2025 09:52:45 +0800 [thread overview]
Message-ID: <5315a702-935e-4a57-a176-cf11823349b4@fnnas.com> (raw)
In-Reply-To: <20251225130326.67780-1-islituo@gmail.com>
在 2025/12/25 21:03, Tuo Li 写道:
> The variable mddev->private is first assigned to conf and then checked:
>
> conf = mddev->private;
> if (!conf) ...
>
> If conf is NULL, then mddev->private is also NULL. In this case,
> null-pointer dereferences can occur when calling raid5_quiesce():
>
> raid5_quiesce(mddev, true);
> raid5_quiesce(mddev, false);
>
> since mddev->private is assigned to conf again in raid5_quiesce(), and conf
> is dereferenced in several places, for example:
>
> conf->quiesce = 0;
> wake_up(&conf->wait_for_quiescent);
>
> To fix this issue, the function should unlock mddev and return before
> invoking raid5_quiesce() when conf is NULL, following the existing pattern
> in raid5_change_consistency_policy().
>
> Fixes: fa1944bbe622 ("md/raid5: Wait sync io to finish before changing group cnt")
> Signed-off-by: Tuo Li<islituo@gmail.com>
> ---
> v2:
> * Move the NULL check and early return ahead of the first call to
> raid5_quiesce().
> Thanks to Yu Kuai for helpful advice.
> ---
> drivers/md/raid5.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Applied to md-6.19
--
Thansk,
Kuai
prev parent reply other threads:[~2025-12-27 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 13:03 Tuo Li
2025-12-26 2:19 ` Xiao Ni
2025-12-26 7:09 ` Paul Menzel
2025-12-27 1:52 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315a702-935e-4a57-a176-cf11823349b4@fnnas.com \
--to=yukuai@fnnas.com \
--cc=islituo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®