* [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c
@ 2020-04-01 10:56 Hu Haowen
2020-04-01 18:24 ` David Miller
2020-04-02 10:43 ` Benjamin Herrenschmidt
0 siblings, 2 replies; 5+ messages in thread
From: Hu Haowen @ 2020-04-01 10:56 UTC (permalink / raw)
To: davem, andrew, mchehab+samsung, andrew, corbet
Cc: stfrench, chris, xiubli, airlied, tglx, benh, hkallweit1, netdev,
linux-kernel, Hu Haowen
"its not" is wrong. The words should be "it's not".
Signed-off-by: Hu Haowen <xianfengting221@163.com>
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 835b7816e372..87236206366f 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
if (rc)
goto cleanup_clk;
- /* RCLK is for RMII, typically used for NCSI. Optional because its not
+ /* RCLK is for RMII, typically used for NCSI. Optional because it's not
* necessary if it's the AST2400 MAC, or the MAC is configured for
* RGMII, or the controller is not an ASPEED-based controller.
*/
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c
2020-04-01 10:56 [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c Hu Haowen
@ 2020-04-01 18:24 ` David Miller
2020-04-02 10:43 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2020-04-01 18:24 UTC (permalink / raw)
To: xianfengting221
Cc: andrew, mchehab+samsung, andrew, corbet, stfrench, chris, xiubli,
airlied, tglx, benh, hkallweit1, netdev, linux-kernel
From: Hu Haowen <xianfengting221@163.com>
Date: Wed, 1 Apr 2020 18:56:24 +0800
> "its not" is wrong. The words should be "it's not".
>
> Signed-off-by: Hu Haowen <xianfengting221@163.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c
2020-04-01 10:56 [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c Hu Haowen
2020-04-01 18:24 ` David Miller
@ 2020-04-02 10:43 ` Benjamin Herrenschmidt
2020-04-02 10:48 ` Andrew Jeffery
2020-04-02 11:13 ` Hu Haowen
1 sibling, 2 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2020-04-02 10:43 UTC (permalink / raw)
To: Hu Haowen, davem, andrew, mchehab+samsung, andrew, corbet
Cc: stfrench, chris, xiubli, airlied, tglx, hkallweit1, netdev, linux-kernel
On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
> "its not" is wrong. The words should be "it's not".
>
> Signed-off-by: Hu Haowen <xianfengting221@163.com>
Typo more than grammer :-)
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
(the offender)
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 835b7816e372..87236206366f 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
> if (rc)
> goto cleanup_clk;
>
> - /* RCLK is for RMII, typically used for NCSI. Optional because its not
> + /* RCLK is for RMII, typically used for NCSI. Optional because it's not
> * necessary if it's the AST2400 MAC, or the MAC is configured for
> * RGMII, or the controller is not an ASPEED-based controller.
> */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c
2020-04-02 10:43 ` Benjamin Herrenschmidt
@ 2020-04-02 10:48 ` Andrew Jeffery
2020-04-02 11:13 ` Hu Haowen
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2020-04-02 10:48 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Hu Haowen, David Miller, Andrew Lunn,
Mauro Carvalho Chehab, Jonathan Corbet
Cc: stfrench, chris, xiubli, airlied, tglx, Heiner Kallweit, netdev,
linux-kernel
On Thu, 2 Apr 2020, at 21:13, Benjamin Herrenschmidt wrote:
> On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
> > "its not" is wrong. The words should be "it's not".
> >
> > Signed-off-by: Hu Haowen <xianfengting221@163.com>
>
> Typo more than grammer :-)
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> (the offender)
No, I am Spartacus!
But yeah:
Acked-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c
2020-04-02 10:43 ` Benjamin Herrenschmidt
2020-04-02 10:48 ` Andrew Jeffery
@ 2020-04-02 11:13 ` Hu Haowen
1 sibling, 0 replies; 5+ messages in thread
From: Hu Haowen @ 2020-04-02 11:13 UTC (permalink / raw)
To: Benjamin Herrenschmidt, davem, andrew, mchehab+samsung, andrew, corbet
Cc: stfrench, chris, xiubli, airlied, tglx, hkallweit1, netdev, linux-kernel
On 2020/4/2 6:43 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
>> "its not" is wrong. The words should be "it's not".
>>
>> Signed-off-by: Hu Haowen <xianfengting221@163.com>
> Typo more than grammer :-)
Emm...
In fact I just found the mistake by accident and decided to fix it up
because it is a standard in the kernel documention not to misspell
words :-)
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> (the offender)
>
>> ---
>> drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
>> index 835b7816e372..87236206366f 100644
>> --- a/drivers/net/ethernet/faraday/ftgmac100.c
>> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
>> @@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
>> if (rc)
>> goto cleanup_clk;
>>
>> - /* RCLK is for RMII, typically used for NCSI. Optional because its not
>> + /* RCLK is for RMII, typically used for NCSI. Optional because it's not
>> * necessary if it's the AST2400 MAC, or the MAC is configured for
>> * RGMII, or the controller is not an ASPEED-based controller.
>> */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-02 11:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 10:56 [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c Hu Haowen
2020-04-01 18:24 ` David Miller
2020-04-02 10:43 ` Benjamin Herrenschmidt
2020-04-02 10:48 ` Andrew Jeffery
2020-04-02 11:13 ` Hu Haowen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®