mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
To: "hdegoede@redhat.com" <hdegoede@redhat.com>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>,
	"zou_wei@huawei.com" <zou_wei@huawei.com>
Cc: "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword
Date: Tue, 8 Dec 2020 15:22:04 +0000	[thread overview]
Message-ID: <194d5a3c2c0f99345454004eb81c08d94181b7d7.camel@intel.com> (raw)
In-Reply-To: <1607430489-116200-1-git-send-email-zou_wei@huawei.com>

On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
> static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
> warning: symbol 'mmio_range_devid_1' was not declared. Should it be
> static?
> 
Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow
configurable offset range" to fix.

Thanks,
Srinivas

> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> index 2906cfe..ff49025 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> @@ -20,12 +20,12 @@ struct isst_mmio_range {
>         int end;
>  };
>  
> -struct isst_mmio_range mmio_range_devid_0[] = {
> +static struct isst_mmio_range mmio_range_devid_0[] = {
>         {0x04, 0x14},
>         {0x20, 0xD0},
>  };
>  
> -struct isst_mmio_range mmio_range_devid_1[] = {
> +static struct isst_mmio_range mmio_range_devid_1[] = {
>         {0x04, 0x14},
>         {0x20, 0x11C},
>  };


  reply	other threads:[~2020-12-08 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 12:28 Zou Wei
2020-12-08 15:22 ` Pandruvada, Srinivas [this message]
2020-12-08 15:27   ` Hans de Goede
2020-12-08 15:29     ` Pandruvada, Srinivas
2020-12-08 15:31 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=194d5a3c2c0f99345454004eb81c08d94181b7d7.camel@intel.com \
    --to=srinivas.pandruvada@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®