[PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[Zou Wei]

Fix the following sparse warnings:

drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: warning: symbol 'mmio_range_devid_0' was not declared. Should it be static?
drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24: warning: symbol 'mmio_range_devid_1' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
index 2906cfe..ff49025 100644
--- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
+++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
@@ -20,12 +20,12 @@ struct isst_mmio_range {
 	int end;
 };
 
-struct isst_mmio_range mmio_range_devid_0[] = {
+static struct isst_mmio_range mmio_range_devid_0[] = {
 	{0x04, 0x14},
 	{0x20, 0xD0},
 };
 
-struct isst_mmio_range mmio_range_devid_1[] = {
+static struct isst_mmio_range mmio_range_devid_1[] = {
 	{0x04, 0x14},
 	{0x20, 0x11C},
 };
-- 
2.6.2

Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[Pandruvada, Srinivas]

On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
> static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
> warning: symbol 'mmio_range_devid_1' was not declared. Should it be
> static?
> 
Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow
configurable offset range" to fix.

Thanks,
Srinivas

> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> index 2906cfe..ff49025 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> @@ -20,12 +20,12 @@ struct isst_mmio_range {
>         int end;
>  };
>  
> -struct isst_mmio_range mmio_range_devid_0[] = {
> +static struct isst_mmio_range mmio_range_devid_0[] = {
>         {0x04, 0x14},
>         {0x20, 0xD0},
>  };
>  
> -struct isst_mmio_range mmio_range_devid_1[] = {
> +static struct isst_mmio_range mmio_range_devid_1[] = {
>         {0x04, 0x14},
>         {0x20, 0x11C},
>  };

Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[Hans de Goede]

Hi,

On 12/8/20 4:22 PM, Pandruvada, Srinivas wrote:
> On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
>> Fix the following sparse warnings:
>>
>> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
>> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
>> static?
>> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
>> warning: symbol 'mmio_range_devid_1' was not declared. Should it be
>> static?
>>
> Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow
> configurable offset range" to fix.

And I replied to that v2 with the following:

"I've already added v1 of these to the for-next branch of:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/

Please send the changes in this v2 as (a) follow-up
patch(es)."

https://lore.kernel.org/platform-driver-x86/2f663d89-184b-f52e-6156-f485205f27f5@redhat.com/T/#t

But I guess you may not have seen this because Intel's mail-servers
seem to have gone completely foobar lately and are bouncing most
of my emails it seems. I strongly suggest that you subscribe to
the platform-driver-x86 lists, so that you at least get replies
to your patches through the list.

So are the changes in this patch from Zou Wei the only changes in v2
of your ISST changes? If that is the case then I'll just merge
Zou Wei's patch and then we're done.

Regards,

Hans



>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
>>  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git
>> a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
>> b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
>> index 2906cfe..ff49025 100644
>> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
>> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
>> @@ -20,12 +20,12 @@ struct isst_mmio_range {
>>         int end;
>>  };
>>  
>> -struct isst_mmio_range mmio_range_devid_0[] = {
>> +static struct isst_mmio_range mmio_range_devid_0[] = {
>>         {0x04, 0x14},
>>         {0x20, 0xD0},
>>  };
>>  
>> -struct isst_mmio_range mmio_range_devid_1[] = {
>> +static struct isst_mmio_range mmio_range_devid_1[] = {
>>         {0x04, 0x14},
>>         {0x20, 0x11C},
>>  };
> 

Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[Pandruvada, Srinivas]

On Tue, 2020-12-08 at 16:27 +0100, Hans de Goede wrote:
> Hi,
> 
> On 12/8/20 4:22 PM, Pandruvada, Srinivas wrote:
> > On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
> > > Fix the following sparse warnings:
> > > 
> > > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
> > > warning: symbol 'mmio_range_devid_0' was not declared. Should it
> > > be
> > > static?
> > > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
> > > warning: symbol 'mmio_range_devid_1' was not declared. Should it
> > > be
> > > static?
> > > 
> > Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow
> > configurable offset range" to fix.
> 
> And I replied to that v2 with the following:
> 
> "I've already added v1 of these to the for-next branch of:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/
> 
> Please send the changes in this v2 as (a) follow-up
> patch(es)."
> 
> https://lore.kernel.org/platform-driver-x86/2f663d89-184b-f52e-6156-f485205f27f5@redhat.com/T/#t
> 
> But I guess you may not have seen this because Intel's mail-servers
> seem to have gone completely foobar lately and are bouncing most
> of my emails it seems. I strongly suggest that you subscribe to
> the platform-driver-x86 lists, so that you at least get replies
> to your patches through the list.
> 
> So are the changes in this patch from Zou Wei the only changes in v2
> of your ISST changes? If that is the case then I'll just merge
> Zou Wei's patch and then we're done.
Fine with me. Just merge Wei's patch.

Thanks,
Srinivas


> 
> Regards,
> 
> Hans
> 
> 
> 
> > > Signed-off-by: Zou Wei <zou_wei@huawei.com>
> > > ---
> > >  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4
> > > ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git
> > > a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> > > b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> > > index 2906cfe..ff49025 100644
> > > --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> > > +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> > > @@ -20,12 +20,12 @@ struct isst_mmio_range {
> > >         int end;
> > >  };
> > >  
> > > -struct isst_mmio_range mmio_range_devid_0[] = {
> > > +static struct isst_mmio_range mmio_range_devid_0[] = {
> > >         {0x04, 0x14},
> > >         {0x20, 0xD0},
> > >  };
> > >  
> > > -struct isst_mmio_range mmio_range_devid_1[] = {
> > > +static struct isst_mmio_range mmio_range_devid_1[] = {
> > >         {0x04, 0x14},
> > >         {0x20, 0x11C},
> > >  };
> > 
> 

Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword

[Hans de Goede]

Hi,

On 12/8/20 1:28 PM, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: warning: symbol 'mmio_range_devid_0' was not declared. Should it be static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24: warning: symbol 'mmio_range_devid_1' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> index 2906cfe..ff49025 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> @@ -20,12 +20,12 @@ struct isst_mmio_range {
>  	int end;
>  };
>  
> -struct isst_mmio_range mmio_range_devid_0[] = {
> +static struct isst_mmio_range mmio_range_devid_0[] = {
>  	{0x04, 0x14},
>  	{0x20, 0xD0},
>  };
>  
> -struct isst_mmio_range mmio_range_devid_1[] = {
> +static struct isst_mmio_range mmio_range_devid_1[] = {
>  	{0x04, 0x14},
>  	{0x20, 0x11C},
>  };
>