From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: thomas.petazzoni@bootlin.com, Jyri Sarha <jsarha@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Benoit Parrot <bparrot@ti.com>,
Lee Jones <lee@kernel.org>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH 0/4] drm/tidss: Fixes data edge sampling
Date: Thu, 7 Aug 2025 16:21:14 +0300 [thread overview]
Message-ID: <1951ecfe-d080-464c-8441-f5400f535495@ideasonboard.com> (raw)
In-Reply-To: <20250730-fix-edge-handling-v1-0-1bdfb3fe7922@bootlin.com>
Hi,
On 30/07/2025 20:02, Louis Chauvet wrote:
> Currently the driver only configure the data edge sampling partially. The
> AM62 require it to be configured in two distincts registers: one in tidss
> and one in the general device registers.
>
> Introduce a new dt property to link the proper syscon node from the main
> device registers into the tidss driver.
>
> Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
> ---
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
I understand why you call this a fix, but I think this is not really a
fix. From looking at the patches, my understanding is that for DPI
outputs we have always only supported certain clock/data edge. So this
series is adding a new feature to the driver.
You can add new things to the DT bindings, but you have to keep the old
bindings working.
Tomi
next prev parent reply other threads:[~2025-08-07 13:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 17:02 Louis Chauvet
2025-07-30 17:02 ` [PATCH 1/4] dt-bindings: display: ti,am65x-dss: Add clk property for data edge synchronization Louis Chauvet
2025-07-30 23:56 ` Rob Herring
2025-07-31 9:50 ` Louis Chauvet
2025-07-30 17:02 ` [PATCH 2/4] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl Louis Chauvet
2025-08-04 8:04 ` Krzysztof Kozlowski
2025-07-30 17:02 ` [PATCH 3/4] arm64: dts: ti: k3-am62-main: Add tidss clk-ctrl property Louis Chauvet
2025-07-31 0:17 ` Rob Herring
2025-07-31 9:50 ` Louis Chauvet
2025-08-05 6:44 ` Krzysztof Kozlowski
2025-08-11 9:56 ` Louis Chauvet
2025-07-30 17:02 ` [PATCH 4/4] drm/tidss: Fix sampling edge configuration Louis Chauvet
2025-08-04 8:06 ` Krzysztof Kozlowski
2025-08-08 13:46 ` devarsh
2025-08-08 16:26 ` Swamil Jain
2025-08-11 9:56 ` Louis Chauvet
2025-08-12 18:02 ` Swamil Jain
2025-08-12 18:10 ` Swamil Jain
2026-07-02 10:48 ` Leonardo Costa
2025-08-07 13:21 ` Tomi Valkeinen [this message]
2025-08-08 13:24 ` [PATCH 0/4] drm/tidss: Fixes data edge sampling devarsh
2025-08-11 7:56 ` Tomi Valkeinen
2025-08-11 9:56 ` Louis Chauvet
2025-10-10 7:42 ` Swamil Jain
2025-10-27 17:53 ` Swamil Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1951ecfe-d080-464c-8441-f5400f535495@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=bparrot@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®