Re: [PATCH v3 2/3] media: v4l2-core: Add support for video encoder ROI control

[Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>]

On 8/4/2026 8:51 PM, Bryan O'Donoghue wrote:
> On 04/08/2026 21:05, Deepa Guthyappa Madivalara wrote:
>> @@ -1588,6 +1606,7 @@ void cur_to_new(struct v4l2_ctrl *ctrl)
>>           return;
>>       if (ctrl->is_dyn_array)
>>           ctrl->new_elems = ctrl->elems;
>> +
>>       ptr_to_ptr(ctrl, ctrl->p_cur, ctrl->p_new, ctrl->new_elems);
>>   }
>>
>> @@ -2030,6 +2049,9 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct 
>> v4l2_ctrl_handler *hdl,
>>       case V4L2_CTRL_TYPE_U32:
>>           elem_size = sizeof(u32);
>>           break;
>> +    case V4L2_CTRL_TYPE_S8:
>> +        elem_size = sizeof(s8);
>> +        break;
>>       case V4L2_CTRL_TYPE_MPEG2_SEQUENCE:
>>           elem_size = sizeof(struct v4l2_ctrl_mpeg2_sequence);
>>           break;
>> @@ -2247,7 +2269,6 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct 
>> v4l2_ctrl_handler *hdl,
>>
>>       if (flags & V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX) {
>>           void *ptr = ctrl->p_def.p;
>> -
>>           if (p_min.p_const) {
>>               ptr += elem_size;
>>               ctrl->p_min.p = ptr;
>
> You're adding and subtracting newlines here in code you otherwise 
> aren't touching.
>
> ---
> bod
>
ack, will fix this in v4