From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dhananjay Phadke <dphadke@linux.microsoft.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver
Date: Thu, 16 Feb 2023 09:08:51 +0100 [thread overview]
Message-ID: <198c084e-66ff-1f3d-33cb-a1339b34336c@linaro.org> (raw)
In-Reply-To: <a62fb259-3ad3-b75e-c59e-2ce937bf799a@linux.microsoft.com>
On 16/02/2023 05:17, Dhananjay Phadke wrote:
> Hi Ryan,
>
> On 2/14/2023 9:43 PM, Ryan Chen wrote:
>> It is not duplicated, as my description in cover " This series add AST2600 i2c new register set driver"
>> So, this will be different driver compatible.
>> The original compatible is
>> - aspeed,ast2400-i2c-bus
>> - aspeed,ast2500-i2c-bus
>> - aspeed,ast2600-i2c-bus
>> So the new register set compatible is "- aspeed,ast2600-i2c", remove "bus".
>
> Is it possible to keep existing driver drivers/i2c/busses/i2c-aspeed.c
> for ast2400/ast2500, while move ast2600 support to new driver
> altogether, say i2c-ast2600.c along with new register mode? By default
> new driver can support legacy mode with same compatible "aspeed,ast2600-
> i2c-bus", additionally driven by dt props, switch to new mode.
So this is for the same hardware? Then the bindings are duplicated.
Driver is actually duplicated as well - rework the old one, instead of
adding this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-16 8:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:33 [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Ryan Chen
2023-02-01 10:33 ` [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller Ryan Chen
2023-02-02 4:25 ` Jeremy Kerr
2023-02-02 5:15 ` Ryan Chen
2023-02-02 8:52 ` Krzysztof Kozlowski
2023-02-01 10:33 ` [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver Ryan Chen
2023-02-02 8:55 ` Krzysztof Kozlowski
2023-02-02 8:57 ` Krzysztof Kozlowski
2023-02-15 5:43 ` Ryan Chen
2023-02-15 20:17 ` Krzysztof Kozlowski
2023-02-16 9:20 ` Ryan Chen
2023-02-16 9:22 ` Krzysztof Kozlowski
2023-02-16 9:26 ` Ryan Chen
2023-02-17 8:37 ` Krzysztof Kozlowski
2023-02-18 1:19 ` Ryan Chen
2023-02-20 7:59 ` Krzysztof Kozlowski
2023-02-20 9:14 ` Ryan Chen
2023-02-20 10:34 ` Krzysztof Kozlowski
2023-02-16 4:17 ` Dhananjay Phadke
2023-02-16 8:08 ` Krzysztof Kozlowski [this message]
2023-02-16 9:17 ` Ryan Chen
2023-02-01 10:33 ` [PATCH v4 3/3] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-02-02 6:04 ` Jeremy Kerr
2023-02-02 9:16 ` Ryan Chen
2023-02-02 9:33 ` Krzysztof Kozlowski
2023-02-02 10:03 ` Ryan Chen
2023-02-14 6:12 ` Ryan Chen
2023-02-14 7:46 ` Krzysztof Kozlowski
2023-02-14 8:57 ` Ryan Chen
2023-02-14 9:32 ` Krzysztof Kozlowski
2023-02-02 8:59 ` Krzysztof Kozlowski
2023-02-02 9:00 ` [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Krzysztof Kozlowski
2023-02-02 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198c084e-66ff-1f3d-33cb-a1339b34336c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=dphadke@linux.microsoft.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®