From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller
Date: Thu, 2 Feb 2023 09:52:45 +0100 [thread overview]
Message-ID: <fcb460cd-f435-e52a-e335-ccea3ac56a30@linaro.org> (raw)
In-Reply-To: <20230201103359.1742140-2-ryan_chen@aspeedtech.com>
On 01/02/2023 11:33, Ryan Chen wrote:
> AST2600 I2C global register controller, add bindings document
> to support driver of i2c global register set.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../i2c/aspeed,i2c-ast2600-global.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml
> new file mode 100644
> index 000000000000..d92a0878d03b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/aspeed,i2c-ast2600-global.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AST2600 I2C Global Register on the AST26XX SoCs Device Tree Bindings
Drop "Device Tree Bindings"
> +
> +maintainers:
> + - Ryan Chen <ryan_chen@aspeedtech.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2600-i2c-global
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
I'll stop review till you test the patches before sending.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-02 8:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:33 [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Ryan Chen
2023-02-01 10:33 ` [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller Ryan Chen
2023-02-02 4:25 ` Jeremy Kerr
2023-02-02 5:15 ` Ryan Chen
2023-02-02 8:52 ` Krzysztof Kozlowski [this message]
2023-02-01 10:33 ` [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver Ryan Chen
2023-02-02 8:55 ` Krzysztof Kozlowski
2023-02-02 8:57 ` Krzysztof Kozlowski
2023-02-15 5:43 ` Ryan Chen
2023-02-15 20:17 ` Krzysztof Kozlowski
2023-02-16 9:20 ` Ryan Chen
2023-02-16 9:22 ` Krzysztof Kozlowski
2023-02-16 9:26 ` Ryan Chen
2023-02-17 8:37 ` Krzysztof Kozlowski
2023-02-18 1:19 ` Ryan Chen
2023-02-20 7:59 ` Krzysztof Kozlowski
2023-02-20 9:14 ` Ryan Chen
2023-02-20 10:34 ` Krzysztof Kozlowski
2023-02-16 4:17 ` Dhananjay Phadke
2023-02-16 8:08 ` Krzysztof Kozlowski
2023-02-16 9:17 ` Ryan Chen
2023-02-01 10:33 ` [PATCH v4 3/3] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-02-02 6:04 ` Jeremy Kerr
2023-02-02 9:16 ` Ryan Chen
2023-02-02 9:33 ` Krzysztof Kozlowski
2023-02-02 10:03 ` Ryan Chen
2023-02-14 6:12 ` Ryan Chen
2023-02-14 7:46 ` Krzysztof Kozlowski
2023-02-14 8:57 ` Ryan Chen
2023-02-14 9:32 ` Krzysztof Kozlowski
2023-02-02 8:59 ` Krzysztof Kozlowski
2023-02-02 9:00 ` [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Krzysztof Kozlowski
2023-02-02 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb460cd-f435-e52a-e335-ccea3ac56a30@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome