From: Jyri Sarha <jsarha@ti.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <tomi.valkeinen@ti.com>,
<airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] drm/tilcdc: mark tilcdc_atomic_check() static
Date: Thu, 22 Sep 2016 19:01:44 +0300 [thread overview]
Message-ID: <199cb69f-fab1-d202-5ee8-70665217c66d@ti.com> (raw)
In-Reply-To: <1474434876-9293-1-git-send-email-baoyou.xie@linaro.org>
Thank,
But I already have this too:
http://www.spinics.net/lists/kernel/msg2340400.html
Best regards,
Jyri
On 09/21/16 08:14, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..1d26bc9 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,7 +61,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
> drm_fbdev_cma_hotplug_event(priv->fbdev);
> }
>
> -int tilcdc_atomic_check(struct drm_device *dev,
> +static int tilcdc_atomic_check(struct drm_device *dev,
> struct drm_atomic_state *state)
> {
> int ret;
>
prev parent reply other threads:[~2016-09-22 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 5:14 Baoyou Xie
2016-09-22 16:01 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199cb69f-fab1-d202-5ee8-70665217c66d@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®