* [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain
@ 2024-11-12 7:41 Rex Nie
2024-11-14 12:12 ` Dmitry Baryshkov
2024-12-03 2:53 ` Abhinav Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Rex Nie @ 2024-11-12 7:41 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, airlied, simona, avrac
Cc: sean, marijn.suijten, jani.nikula, mgonzalez, rex.nie,
linux-arm-msm, dri-devel, freedreno, linux-kernel, angus.chen
In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL,
so the base may be 63, 126, 196, 392. The condition base <= 2046
always true.
Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support")
Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
index e6ffaf92d26d..1c4211cfa2a4 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
@@ -137,7 +137,7 @@ static inline u32 pll_get_integloop_gain(u64 frac_start, u64 bclk, u32 ref_clk,
base <<= (digclk_divsel == 2 ? 1 : 0);
- return (base <= 2046 ? base : 2046);
+ return base;
}
static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain
2024-11-12 7:41 [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain Rex Nie
@ 2024-11-14 12:12 ` Dmitry Baryshkov
2024-12-03 2:53 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-11-14 12:12 UTC (permalink / raw)
To: Rex Nie
Cc: robdclark, quic_abhinavk, airlied, simona, avrac, sean,
marijn.suijten, jani.nikula, mgonzalez, linux-arm-msm, dri-devel,
freedreno, linux-kernel, angus.chen
On Tue, Nov 12, 2024 at 03:41:00PM +0800, Rex Nie wrote:
> In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL,
> so the base may be 63, 126, 196, 392. The condition base <= 2046
> always true.
>
> Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support")
> Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain
2024-11-12 7:41 [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain Rex Nie
2024-11-14 12:12 ` Dmitry Baryshkov
@ 2024-12-03 2:53 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2024-12-03 2:53 UTC (permalink / raw)
To: Rex Nie, robdclark, dmitry.baryshkov, airlied, simona, avrac
Cc: sean, marijn.suijten, jani.nikula, mgonzalez, linux-arm-msm,
dri-devel, freedreno, linux-kernel, angus.chen
On 11/11/2024 11:41 PM, Rex Nie wrote:
> In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL,
> so the base may be 63, 126, 196, 392. The condition base <= 2046
> always true.
>
> Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support")
> Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-03 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 7:41 [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain Rex Nie
2024-11-14 12:12 ` Dmitry Baryshkov
2024-12-03 2:53 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®