[PATCH] latencytop: Use seq_putc() in lstats_show()

[PATCH] latencytop: Use seq_putc() in lstats_show()

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 14 Jul 2024 11:52:13 +0200

A single line break should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/latencytop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/latencytop.c b/kernel/latencytop.c
index 84c53285f499..09e5231598ae 100644
--- a/kernel/latencytop.c
+++ b/kernel/latencytop.c
@@ -260,7 +260,7 @@ static int lstats_show(struct seq_file *m, void *v)

 				seq_printf(m, " %ps", (void *)bt);
 			}
-			seq_puts(m, "\n");
+			seq_putc(m, '\n');
 		}
 	}
 	return 0;
--
2.45.2

Re: [PATCH] latencytop: Use seq_putc() in lstats_show()

[Joel Granados]

On Sun, Jul 14, 2024 at 12:00:23PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 14 Jul 2024 11:52:13 +0200

Not sure why this got forwarded to me. ccing arjan@linux.intel.com
as he seems to be the author of the file.
> 
> A single line break should be put into a sequence.
> Thus use the corresponding function “seq_putc”.
> 
> This issue was transformed by using the Coccinelle software.

A couple of comments while I'm here:
* The "why" is not clear; please clarify why a single line break should
  be put into a sequence.
* I don't think that a one liner merits the "coccinelle" comment.
  However, if you *really* think it should be there, please add more
  information, like the conccinell script.

Best

-- 

Joel Granados

Re: latencytop: Use seq_putc() in lstats_show()

[Markus Elfring]

> Not sure why this got forwarded to me.

The script “get_maintainer.pl” pointed your recent contribution out.


>> A single line break should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
>
> A couple of comments while I'm here:
> * The "why" is not clear; please clarify why a single line break should
>   be put into a sequence.

This is a desired data processing effect here.
https://elixir.bootlin.com/linux/v6.10/source/kernel/latencytop.c#L263


> * I don't think that a one liner merits the "coccinelle" comment.
>   However, if you *really* think it should be there, please add more
>   information, like the conccinell script.

I would appreciate if another SmPL script can eventually be integrated
for the coccicheck tool.

Regards,
Markus

Re: latencytop: Use seq_putc() in lstats_show()

[Joel Granados]

On Tue, Jul 16, 2024 at 07:06:06PM +0200, Markus Elfring wrote:
> > Not sure why this got forwarded to me.
> 
> The script “get_maintainer.pl” pointed your recent contribution out.
Makes sense. I'll still defer to arjan@linux.intel.com.

-- 

Joel Granados