From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Andi Kleen" <andi@firstfloor.org>
Cc: "Pekka Enberg" <penberg@cs.helsinki.fi>,
"Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemcheck: don't track pages allocated with interrupts disabled
Date: Sat, 7 Jun 2008 20:18:11 +0200 [thread overview]
Message-ID: <19f34abd0806071118j1089d940r42440abbcf7e9829@mail.gmail.com> (raw)
In-Reply-To: <484AC165.7000702@firstfloor.org>
On Sat, Jun 7, 2008 at 7:12 PM, Andi Kleen <andi@firstfloor.org> wrote:
> But a far better solution is to just split all the pages in the system
> with set_memory_4k() at boot time (and memory hot add time) when you
> know you're not in interrupt context.
>
> I believe that would be the right solution for DEBUG_PAGEALLOC too.
Ah, this is very true for more than one reason. We only ever touch
kernel pages with kmemcheck. So this means that userspace can still
use large pages and save memory with that. This wouldn't work when we
disable PSE entirely.
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
prev parent reply other threads:[~2008-06-07 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 14:32 Vegard Nossum
2008-06-07 17:12 ` Andi Kleen
2008-06-07 18:15 ` Vegard Nossum
2008-06-07 19:47 ` Andi Kleen
2008-06-07 20:19 ` Vegard Nossum
2008-06-07 18:18 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0806071118j1089d940r42440abbcf7e9829@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®