mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemcheck: don't track pages allocated with interrupts disabled
Date: Sat, 07 Jun 2008 19:12:05 +0200	[thread overview]
Message-ID: <484AC165.7000702@firstfloor.org> (raw)
In-Reply-To: <20080607143242.GA2893@damson.getinternet.no>

Vegard Nossum wrote:
> It seems that I was wrong regarding the set_memory_4k() approach. It seems
> to only have worked because we were lucky. 

You just put it in the wrong place I think.

> We may later reinstate the code
> to disable PSE, but this time not unconditionally, perhaps with a config
> option or boot-time option.

It would be kind of guaranteed (not sure 100%) together with
CONFOG_DEBUG_PAGEALLOC and Thomas' page table pool (the pool is ifdefed
on that)

But a far better solution is to just split all the pages in  the system
with set_memory_4k() at boot time  (and memory hot add time) when you
know you're not in interrupt context.

I believe that would be the right solution for DEBUG_PAGEALLOC too.

-Andi


  reply	other threads:[~2008-06-07 17:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-07 14:32 Vegard Nossum
2008-06-07 17:12 ` Andi Kleen [this message]
2008-06-07 18:15   ` Vegard Nossum
2008-06-07 19:47     ` Andi Kleen
2008-06-07 20:19       ` Vegard Nossum
2008-06-07 18:18   ` Vegard Nossum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484AC165.7000702@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®