From: Vegard Nossum <vegard.nossum@gmail.com>
To: Bart Van Assche <bart.vanassche@gmail.com>
Cc: linux-kernel@vger.kernel.org, Vegard Nossum <vegardno@ifi.uio.no>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2.6.31.1] include/linux/kmemcheck.h: fix a sparse warning
Date: Fri, 2 Oct 2009 09:51:16 +0200 [thread overview]
Message-ID: <19f34abd0910020051h5a831729vcfca50b7bd9f9104@mail.gmail.com> (raw)
In-Reply-To: <e2e108260910012341v5eab14c5o29da95ec52e75183@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 2289 bytes --]
2009/10/2 Bart Van Assche <bart.vanassche@gmail.com>:> On Sat, Sep 26, 2009 at 2:28 PM, Bart Van Assche> <bart.vanassche@gmail.com> wrote:>>>> Checking a 2.6.31.1 kernel configured with allyesconfig/allmodconfig>> with sparse (make C=2) triggers a sparse warning on code that uses the>> kmemcheck_annotate_bitfield() macro. An example of such a warning:>>>> include/net/inet_sock.h:208:17: warning: do-while statement is not a compound statement>>>> Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>>> Cc: Vegard Nossum <vegardno@ifi.uio.no>>> Cc: Andrew Morton <akpm@linux-foundation.org>>>>> --- linux-2.6.31.1/include/linux/kmemcheck-orig.h    2009-09-26 13:53:44.000000000 +0200>> +++ linux-2.6.31.1/include/linux/kmemcheck.h   2009-09-26 13:53:56.000000000 +0200>> @@ -137,13 +137,13 @@ static inline void kmemcheck_mark_initia>>     int name##_end[0];>>>>  #define kmemcheck_annotate_bitfield(ptr, name)             \>> -    do if (ptr) {                          \>> +    do { if (ptr) {                         \>>         int _n = (long) &((ptr)->name##_end)           \>>             - (long) &((ptr)->name##_begin);         \>>         BUILD_BUG_ON(_n < 0);                  \>>                                     \>>         kmemcheck_mark_initialized(&((ptr)->name##_begin), _n); \>> -    } while (0)>> +    } } while (0)>>>>  #define kmemcheck_annotate_variable(var)                \>>     do {                               \>> (ping)>> Did anyone already have the time to review the patch above ?>> Bart.
Hi,
A patch for this problem has already been applied in latest mainline.Thanks anyway, and sorry for not responding sooner.
Vegardÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2009-10-02 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 12:28 Bart Van Assche
2009-10-02 6:41 ` Bart Van Assche
2009-10-02 7:51 ` Vegard Nossum [this message]
2009-10-14 7:06 ` Bart Van Assche
2009-10-14 11:26 ` Vegard Nossum
2009-10-14 11:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0910020051h5a831729vcfca50b7bd9f9104@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bart.vanassche@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®