mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Sibi Sankar <quic_sibis@quicinc.com>,
	konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org,
	abel.vesa@linaro.org, srinivas.kandagatla@linaro.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
Date: Tue, 01 Oct 2024 09:56:30 +0300	[thread overview]
Message-ID: <1BBC34CC-92D9-4F6E-8DFA-1F2DA36D545A@linaro.org> (raw)
In-Reply-To: <eqy4yicgeqlgaytgzybnitvbrdr7jmjjk5k2swmadad6scwk77@ubaf7a2kgmdm>

On October 1, 2024 5:42:35 AM GMT+03:00, Bjorn Andersson <andersson@kernel.org> wrote:
>On Wed, Sep 11, 2024 at 10:55:05AM GMT, Dmitry Baryshkov wrote:
>> On Wed, Sep 11, 2024 at 01:03:37PM GMT, Sibi Sankar wrote:
>[..]
>> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>[..]
>> > +
>> > +&pcie5 {
>> > +	perst-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>;
>> > +	wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>;
>> > +
>> > +	vddpe-3v3-supply = <&vreg_wwan>;
>> 
>> Please use pwrseq instead.
>> 
>
>What benefit is there to wrap a single 3.3V regulator in pwrseq driver?

First of all, is it really just a 3.3V? Second, is it actually powering up the host controller (as expressed in the device tree? Is it a power supply to the slot (in this case, I think, it should be expressed differently)? Or is it a power supply to the card itself?


>
>> > +
>> > +	pinctrl-0 = <&pcie5_default>;
>> > +	pinctrl-names = "default";
>> > +
>> > +	status = "okay";
>> > +};
>> > +
>> > +&pcie5_phy {
>> > +	vdda-phy-supply = <&vreg_l3i_0p8>;
>> > +	vdda-pll-supply = <&vreg_l3e_1p2>;
>> > +
>> > +	status = "okay";
>> > +};
>> > +
>> > +&pcie6a {
>> > +	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
>> > +	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
>> > +
>> > +	vddpe-3v3-supply = <&vreg_nvme>;
>> 
>> Please use pwrseq instead.
>> 
>
>Ditto


Same set of questions.

>
>Regards,
>Bjorn


-- 
With best wishes
Dmitry

  reply	other threads:[~2024-10-01  6:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  7:33 [PATCH 0/2] " Sibi Sankar
2024-09-11  7:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add " Sibi Sankar
2024-09-11 15:44   ` Jeff Johnson
2024-10-05 15:25     ` Sibi Sankar
2024-09-16 17:20   ` Rob Herring (Arm)
2024-09-11  7:33 ` [PATCH 2/2] arm64: dts: qcom: Add X1E001DE " Sibi Sankar
2024-09-11  7:55   ` Dmitry Baryshkov
2024-10-01  2:42     ` Bjorn Andersson
2024-10-01  6:56       ` Dmitry Baryshkov [this message]
2024-10-01  8:51         ` Manivannan Sadhasivam
2024-10-05 19:03           ` Sibi Sankar
2024-10-06 17:06             ` Dmitry Baryshkov
2024-10-06 18:01             ` Manivannan Sadhasivam
2024-10-15 13:51               ` Manivannan Sadhasivam
2024-10-15 13:57                 ` Dmitry Baryshkov
2024-10-15 15:27                   ` Manivannan Sadhasivam
2024-10-16 10:14                     ` Dmitry Baryshkov
2024-10-05 18:43     ` Sibi Sankar
2024-10-23 11:05 ` [PATCH 0/2] " Sibi Sankar
2024-10-23 20:46   ` Rob Clark
2024-10-24  5:13   ` Jens Glathe
2024-10-24  5:30   ` Jens Glathe
2024-10-24  8:14   ` neil.armstrong
2024-10-24 16:02   ` Marc Zyngier
2024-10-24 16:15     ` Johan Hovold
2024-10-24 16:28       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1BBC34CC-92D9-4F6E-8DFA-1F2DA36D545A@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_sibis@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®