* [PATCH] clk: tegra: fix error return case for recalc_rate
@ 2023-09-12 11:29 Mikko Perttunen
2023-09-12 17:58 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Mikko Perttunen @ 2023-09-12 11:29 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter
Cc: Timo Alho, Mikko Perttunen, Peter De Schrijver, Prashant Gaikwad,
Michael Turquette, Stephen Boyd, linux-clk, linux-tegra,
linux-kernel
From: Timo Alho <talho@nvidia.com>
tegra-bpmp clocks driver makes implicit conversion of signed error
code to unsigned value in recalc_rate operation. The behavior for
recalc_rate, according to it's specification, should be that "If the
driver cannot figure out a rate for this clock, it must return 0."
Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
Signed-off-by: Timo Alho <talho@nvidia.com>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/clk/tegra/clk-bpmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index a9f3fb448de6..7bfba0afd778 100644
--- a/drivers/clk/tegra/clk-bpmp.c
+++ b/drivers/clk/tegra/clk-bpmp.c
@@ -159,7 +159,7 @@ static unsigned long tegra_bpmp_clk_recalc_rate(struct clk_hw *hw,
err = tegra_bpmp_clk_transfer(clk->bpmp, &msg);
if (err < 0)
- return err;
+ return 0;
return response.rate;
}
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] clk: tegra: fix error return case for recalc_rate
2023-09-12 11:29 [PATCH] clk: tegra: fix error return case for recalc_rate Mikko Perttunen
@ 2023-09-12 17:58 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2023-09-12 17:58 UTC (permalink / raw)
To: Jonathan Hunter, Mikko Perttunen, Thierry Reding
Cc: Timo Alho, Mikko Perttunen, Peter De Schrijver, Prashant Gaikwad,
Michael Turquette, linux-clk, linux-tegra, linux-kernel
Quoting Mikko Perttunen (2023-09-12 04:29:50)
> From: Timo Alho <talho@nvidia.com>
>
> tegra-bpmp clocks driver makes implicit conversion of signed error
> code to unsigned value in recalc_rate operation. The behavior for
> recalc_rate, according to it's specification, should be that "If the
> driver cannot figure out a rate for this clock, it must return 0."
>
> Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
> Signed-off-by: Timo Alho <talho@nvidia.com>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-12 17:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 11:29 [PATCH] clk: tegra: fix error return case for recalc_rate Mikko Perttunen
2023-09-12 17:58 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®