From: bot+bpf-ci@kernel.org
To: jarkko@kernel.org,linux-fsdevel@vger.kernel.org
Cc: jarkko@kernel.org,bpf@vger.kernel.org,containers@lists.linux.dev,linux-api@vger.kernel.org,linux-arch@vger.kernel.org,linux-doc@vger.kernel.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-mm@kvack.org,linux-security-module@vger.kernel.org,aleksa@amutable.com,alex@amutable.com,viro@zeniv.linux.org.uk,luto@amacapital.net,arnd@arndb.de,brauner@kernel.org,dhowells@redhat.com,giuseppe@scrivano.org,hughd@google.com,jack@suse.cz,jlayton@kernel.org,corbet@lwn.net,josef@toxicpanda.com,kees@kernel.org,kpsingh@kernel.org,lennart@poettering.net,neal@gompa.dev,oleg@redhat.com,paul@paul-moore.com,ptikhomirov@virtuozzo.com,sergeh@kernel.org,skhan@linuxfoundation.org,zygmunt.krynicki@canonical.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [RFC PATCH v6 15/26] exit: Support P_USERLAND in waitid()
Date: Sun, 22 Nov 2026 02:13:22 +0000 (UTC) [thread overview]
Message-ID: <1a12b0b293d0622a6a3f897306f3cf2256be88befcfdc0bf272ceeb1de6bcac6@mail.kernel.org> (raw)
In-Reply-To: <20261122011809.2667684-16-jarkko@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3082 bytes --]
> exit: Support P_USERLAND in waitid()
TL;DR: A blocking waitid(P_USERLAND) may return an unexpected -EAGAIN if a
failed clone3() bootstrap is retried while it sleeps; it should probably
return -ECHILD or keep waiting.
> diff --git a/kernel/userland.c b/kernel/userland.c
> --- a/kernel/userland.c
> +++ b/kernel/userland.c
[ ... ]
> +/**
> + * DOC: P_USERLAND
> + *
> + * ``waitid(P_USERLAND, userland_fd, &infop, options, NULL)`` waits freezably until
> + * ``userland_fd`` reaches ``USERLAND_DEAD`` (unless ``WNOHANG`` or ``O_NONBLOCK`` is
> + * set) and writes init's exit information into ``infop`` without consuming it.
[ ... ]
> + if (!nonblock) {
> + ret = wait_event_freezable(userland->waitq,
> + READ_ONCE(userland->state) ==
> + USERLAND_DEAD ||
> + READ_ONCE(userland->state) ==
> + USERLAND_INIT);
> + if (ret)
> + return ret;
> + }
> +
> + scoped_guard(spinlock, &userland->lock) {
> + if (userland->state == USERLAND_INIT)
> + return -ECHILD;
> + if (userland->state != USERLAND_DEAD)
> + return (options & WNOHANG) ? 0 : -EAGAIN;
Can a blocking waitid(P_USERLAND) return -EAGAIN here, even though the DOC
comment says it waits until USERLAND_DEAD unless WNOHANG or O_NONBLOCK is
set?
The wait above ends on DEAD or INIT, but userland->lock is only taken after
the wait returns, so the state can change in between. INIT is not terminal
once 498ccb2ffbc4 ("fork: Support CLONE_INTO_USERLAND in clone3()") is
applied: userland_finish_fork() sets FORKING back to INIT under
userland->lock when copy_process() fails, and then calls
wake_up_all(&userland->waitq).
Sequence:
Task A: waitid(P_USERLAND, fd, &si, WEXITED, NULL), blocking fd
passes the early INIT check and sleeps in wait_event_freezable()
Task B: clone3(CLONE_INTO_USERLAND), state is FORKING
copy_process() fails (e.g. -EAGAIN from RLIMIT_NPROC)
userland_finish_fork() sets INIT and wakes A
Task B or C: retries clone3(CLONE_INTO_USERLAND)
userland_prepare_fork() sees INIT and sets FORKING again
Task A: takes userland->lock, state is FORKING or RUNNING,
neither INIT nor DEAD, WNOHANG is clear, returns -EAGAIN
With neither WNOHANG nor O_NONBLOCK set, waitid() does not return -EAGAIN
for P_PID or P_PIDFD, so a manager doing a blocking wait gets an error it has
no reason to expect, possibly while the new init is running.
In the !nonblock case a non-DEAD state under the lock means a bootstrap
failed, so should this return -ECHILD like the early INIT check, or go back
to waiting? -EAGAIN and 0 would then only apply to the nonblock case.
userland_waitid() is unchanged through the end of the series, so no later
commit fixes this. The path is only reachable once 498ccb2ffbc4 adds the
FORKING state; in this commit the state never leaves INIT.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44972669664
next prev parent reply other threads:[~2026-11-22 2:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 1:17 [RFC PATCH v6 00/26] userland: Userland containers Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 01/26] userns: Factor out idmap validation and commit helpers Jarkko Sakkinen
2026-11-22 1:57 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 02/26] userns: Add userns_set_idmap() system call Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 03/26] arch: Wire up " Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 04/26] mount: Add mnt_ns_get_root() Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 05/26] mount: Enforce mount_too_revealing() for foreign mntns Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 06/26] mount: Support MOVE_MOUNT_T_MNTNS in move_mount() Jarkko Sakkinen
2026-11-22 2:14 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 07/26] mount: Support MOVE_MOUNT_CLONE with MOVE_MOUNT_T_MNTNS Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 08/26] userns: Factor out install_user_ns_cred() Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 09/26] nsproxy: Expose create_new_namespaces() Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 10/26] userland: Add core infrastructure Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 11/26] userland: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 12/26] userland: Add userland_open() system call Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 13/26] userland: Add USERLAND_GET_NSFD ioctl Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:17 ` [RFC PATCH v6 14/26] userland: Add USERLAND_SHARE_NSFD ioctl Jarkko Sakkinen
2026-11-22 1:17 ` [RFC PATCH v6 15/26] exit: Support P_USERLAND in waitid() Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci [this message]
2026-11-22 1:17 ` [RFC PATCH v6 16/26] signal: Support userland fds in pidfd_send_signal() Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:18 ` [RFC PATCH v6 17/26] fork: Support CLONE_INTO_USERLAND in clone3() Jarkko Sakkinen
2026-11-22 2:14 ` bot+bpf-ci
2026-11-22 1:18 ` [RFC PATCH v6 18/26] fs: Support FSCONFIG_SET_USERLAND in fsconfig() Jarkko Sakkinen
2026-11-22 2:13 ` bot+bpf-ci
2026-11-22 1:18 ` [RFC PATCH v6 19/26] proc: Implement ->set_userland() fs_context operation Jarkko Sakkinen
2026-11-22 1:18 ` [RFC PATCH v6 20/26] ipc/mqueue: " Jarkko Sakkinen
2026-11-22 1:18 ` [RFC PATCH v6 21/26] security: Add userland LSM hooks Jarkko Sakkinen
2026-11-22 1:18 ` [RFC PATCH v6 22/26] bpf: Register " Jarkko Sakkinen
2026-11-22 1:18 ` [RFC PATCH v6 23/26] arch: Wire up userland_open() system call Jarkko Sakkinen
2026-11-22 1:18 ` [RFC PATCH v6 24/26] docs: Document userland uAPI Jarkko Sakkinen
2026-11-22 1:56 ` bot+bpf-ci
2026-11-22 1:18 ` [RFC PATCH v6 25/26] selftests/userland: Add userland test suite Jarkko Sakkinen
2026-11-22 2:14 ` bot+bpf-ci
2026-11-22 1:18 ` [RFC PATCH v6 26/26] MAINTAINERS: Add entry for USERLAND Jarkko Sakkinen
2026-11-22 1:58 ` [RFC PATCH v6 00/26] userland: Userland containers Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a12b0b293d0622a6a3f897306f3cf2256be88befcfdc0bf272ceeb1de6bcac6@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=aleksa@amutable.com \
--cc=alex@amutable.com \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=containers@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=eddyz87@gmail.com \
--cc=giuseppe@scrivano.org \
--cc=hughd@google.com \
--cc=ihor.solodrai@linux.dev \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kees@kernel.org \
--cc=kpsingh@kernel.org \
--cc=lennart@poettering.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=neal@gompa.dev \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=sergeh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yonghong.song@linux.dev \
--cc=zygmunt.krynicki@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®