* [PATCH] ata:do not initialise statics to 0
@ 2022-07-19 11:42 Xin Gao
2022-07-19 11:45 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Xin Gao @ 2022-07-19 11:42 UTC (permalink / raw)
To: damien.lemoal; +Cc: linux-ide, linux-kernel, Xin Gao
do not initialise statics to 0
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 40e816419f48..bbb98433d160 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -119,7 +119,7 @@ static int atapi_enabled = 1;
module_param(atapi_enabled, int, 0444);
MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on [default])");
-static int atapi_dmadir = 0;
+static int atapi_dmadir;
module_param(atapi_dmadir, int, 0444);
MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off [default], 1=on)");
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ata:do not initialise statics to 0
2022-07-19 11:42 [PATCH] ata:do not initialise statics to 0 Xin Gao
@ 2022-07-19 11:45 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2022-07-19 11:45 UTC (permalink / raw)
To: Xin Gao; +Cc: linux-ide, linux-kernel
On 7/19/22 20:42, Xin Gao wrote:
> do not initialise statics to 0
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 40e816419f48..bbb98433d160 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -119,7 +119,7 @@ static int atapi_enabled = 1;
> module_param(atapi_enabled, int, 0444);
> MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on [default])");
>
> -static int atapi_dmadir = 0;
> +static int atapi_dmadir;
> module_param(atapi_dmadir, int, 0444);
> MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off [default], 1=on)");
>
Is this solving any static analyzer or compiler warning ? If not, this is
not a very useful change.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-19 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 11:42 [PATCH] ata:do not initialise statics to 0 Xin Gao
2022-07-19 11:45 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®