From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Alistair Delva <adelva@google.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Jakub Kicinski" <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
kernel-team@android.com, "Maciej Żenczykowski" <maze@google.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>
Subject: Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller
Date: Sun, 1 Nov 2020 23:34:11 +0000 [thread overview]
Message-ID: <1a85a545-a663-828a-387e-fd4a0e2ae747@gmail.com> (raw)
In-Reply-To: <20201101220845.2391858-1-adelva@google.com>
On 11/1/20 10:08 PM, Alistair Delva wrote:
> The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are
> enabled instead of SLAB, which breaks the build on such configs when
> CONFIG_XFRM_USER_COMPAT=m.
>
> ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
>
> Other users of this symbol are 'bool' options, but changing this to
> bool would require XFRM_USER to be built in as well, which doesn't
> seem worth it. Go back to kmalloc().
>
> Fixes: 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr")
> Cc: Dmitry Safonov <0x7f454c46@gmail.com>
> Cc: Maciej Żenczykowski <maze@google.com>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Signed-off-by: Alistair Delva <adelva@google.com>
Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>
Thank you!
--
Dmitry
next prev parent reply other threads:[~2020-11-01 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 22:08 Alistair Delva
2020-11-01 23:34 ` Dmitry Safonov [this message]
2020-11-02 3:38 ` Herbert Xu
2020-11-02 4:08 ` Alistair Delva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a85a545-a663-828a-387e-fd4a0e2ae747@gmail.com \
--to=0x7f454c46@gmail.com \
--cc=adelva@google.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®