From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v7 4/6] selftests/resctrl: Cleanup properly when an error occurs in CAT test
Date: Mon, 13 Feb 2023 11:20:08 -0800 [thread overview]
Message-ID: <1a933b7c-0318-ce06-9239-197d78c9889d@intel.com> (raw)
In-Reply-To: <616c7fab-65ad-17b7-f360-94b7e22f892@linux.intel.com>
On 2/13/2023 2:00 AM, Ilpo Järvinen wrote:
> On Mon, 13 Feb 2023, Shaopeng Tan wrote:
>
>> After creating a child process with fork() in CAT test, if an error
>> occurs when parent process runs cat_val() or check_results(), the child
>
> I'd replace the rest of the paragraph with this:
>
> "returns early. The parent will wait pipe message from child which will
> never be sent by the child and the parent cannot proceeed to unmount
> resctrlfs."
Note that the description is about an error within the parent process.
In the case snipped above it is the parent that exits early, not the child.
This first paragraph describes two scenarios, (a) error in parent, and (b)
error in child. I think it is good information to keep descriptions of
both scenarios.
The proposed addition could be used to expand the description of the scenario
when an error occurs in the child. In this case please consider changing "wait
pipe message from child" to "wait for the pipe message from the child", and
"proceeed" to "proceed".
Reinette
next prev parent reply other threads:[~2023-02-13 19:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 6:24 [PATCH v7 0/6] Some improvements of resctrl selftest Shaopeng Tan
2023-02-13 6:24 ` [PATCH v7 1/6] selftests/resctrl: Fix set up schemata with 100% allocation on first run in MBM test Shaopeng Tan
2023-02-13 6:24 ` [PATCH v7 2/6] selftests/resctrl: Return MBA check result and make it to output message Shaopeng Tan
2023-02-13 6:24 ` [PATCH v7 3/6] selftests/resctrl: Flush stdout file buffer before executing fork() Shaopeng Tan
2023-02-13 6:24 ` [PATCH v7 4/6] selftests/resctrl: Cleanup properly when an error occurs in CAT test Shaopeng Tan
2023-02-13 10:00 ` Ilpo Järvinen
2023-02-13 19:20 ` Reinette Chatre [this message]
2023-02-14 9:41 ` Ilpo Järvinen
2023-02-13 19:21 ` Reinette Chatre
2023-02-13 6:24 ` [PATCH v7 5/6] selftests/resctrl: Commonize the signal handler register/unregister for all tests Shaopeng Tan
2023-02-13 10:29 ` Ilpo Järvinen
2023-02-13 19:21 ` Reinette Chatre
2023-02-13 6:24 ` [PATCH v7 6/6] selftests/resctrl: Remove duplicate codes that clear each test result file Shaopeng Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a933b7c-0318-ce06-9239-197d78c9889d@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®