mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v7 5/6] selftests/resctrl: Commonize the signal handler register/unregister for all tests
Date: Mon, 13 Feb 2023 11:21:19 -0800	[thread overview]
Message-ID: <a7f1d984-21b6-0bc8-519d-6d2c5e310381@intel.com> (raw)
In-Reply-To: <20230213062428.1721572-6-tan.shaopeng@jp.fujitsu.com>

Hi Shaopeng,

On 2/12/2023 10:24 PM, Shaopeng Tan wrote:
> After creating a child process with fork() in CAT test, if a signal such
> as SIGINT is received, the parent process will be terminated immediately,
> and therefor the child process will not be killed and also resctrlfs is
> not unmounted.
> 
> There is a signal handler registered in CMT/MBM/MBA tests, which kills
> child process, unmount resctrlfs, cleanups result files, etc., if a
> signal such as SIGINT is received.
> 
> Commonize the signal handler registered for CMT/MBM/MBA tests and
> reuse it in CAT.
> 
> To reuse the signal handler to kill child process use global bm_pid
> instead of local bm_pid.
> 
> Also, since the MBA/MBA/CMT/CAT are run in order, unregister the signal
> handler at the end of each test so that the signal handler cannot be
> inherited by other tests.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you very much

Reinette

  parent reply	other threads:[~2023-02-13 19:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  6:24 [PATCH v7 0/6] Some improvements of resctrl selftest Shaopeng Tan
2023-02-13  6:24 ` [PATCH v7 1/6] selftests/resctrl: Fix set up schemata with 100% allocation on first run in MBM test Shaopeng Tan
2023-02-13  6:24 ` [PATCH v7 2/6] selftests/resctrl: Return MBA check result and make it to output message Shaopeng Tan
2023-02-13  6:24 ` [PATCH v7 3/6] selftests/resctrl: Flush stdout file buffer before executing fork() Shaopeng Tan
2023-02-13  6:24 ` [PATCH v7 4/6] selftests/resctrl: Cleanup properly when an error occurs in CAT test Shaopeng Tan
2023-02-13 10:00   ` Ilpo Järvinen
2023-02-13 19:20     ` Reinette Chatre
2023-02-14  9:41       ` Ilpo Järvinen
2023-02-13 19:21   ` Reinette Chatre
2023-02-13  6:24 ` [PATCH v7 5/6] selftests/resctrl: Commonize the signal handler register/unregister for all tests Shaopeng Tan
2023-02-13 10:29   ` Ilpo Järvinen
2023-02-13 19:21   ` Reinette Chatre [this message]
2023-02-13  6:24 ` [PATCH v7 6/6] selftests/resctrl: Remove duplicate codes that clear each test result file Shaopeng Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7f1d984-21b6-0bc8-519d-6d2c5e310381@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®