From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
Pavan Kondeti <pkondeti@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, vincent.guittot@linaro.org,
morten.rasmussen@arm.com, qperret@google.com,
adharmap@codeaurora.org
Subject: Re: [PATCH v3 1/3] sched/fair: Add asymmetric CPU capacity wakeup scan
Date: Wed, 29 Jan 2020 11:38:37 +0100 [thread overview]
Message-ID: <1aa14491-517e-92d2-08b0-568338d75812@arm.com> (raw)
In-Reply-To: <1ed322d6-0325-ecac-cc68-326a14b8c1dd@arm.com>
On 28/01/2020 12:30, Valentin Schneider wrote:
> Hi Pavan,
>
> On 28/01/2020 06:22, Pavan Kondeti wrote:
>> Hi Valentin,
>>
>> On Sun, Jan 26, 2020 at 08:09:32PM +0000, Valentin Schneider wrote:
[...]
>>> +
>>> + if (!static_branch_unlikely(&sched_asym_cpucapacity))
>>> + return -1;
We do need this one to bail out quickly on non CPU asym systems. (1)
>>> + sd = rcu_dereference(per_cpu(sd_asym_cpucapacity, target));
>>> + if (!sd)
>>> + return -1;
And I assume we can't return target here because of exclusive cpusets
which can form symmetric CPU capacities islands on a CPU asymmetric
system? (2)
>>> + sync_entity_load_avg(&p->se);
>>> +
>>> + cpus = this_cpu_cpumask_var_ptr(select_idle_mask);
>>> + cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr);
>>> +
>>> + for_each_cpu_wrap(cpu, cpus, target) {
>>> + rq = cpu_rq(cpu);
>>> +
>>> + if (!available_idle_cpu(cpu))
>>> + continue;
>>> + if (task_fits_capacity(p, rq->cpu_capacity))
>>> + return cpu;
>>
>> I have couple of questions.
[...]
>> (2) Assuming all CPUs are busy, we return -1 from here and end up
>> calling select_idle_cpu(). The traversal in select_idle_cpu() may be
>> waste in cases where sd_llc == sd_asym_cpucapacity . For example SDM845.
>> Should we worry about this?
>>
>
> Before v3, since we didn't have the fallback CPU selection within
> select_idle_capacity(), we would need the fall-through to select_idle_cpu()
> (we could've skipped an idle CPU just because its capacity wasn't high
> enough).
>
> That's not the case anymore, so indeed we may be able to bail out of
> select_idle_sibling() right after select_idle_capacity() (or after the
> prev / recent_used_cpu checks). Our only requirement here is that sd_llc
> remains a subset of sd_asym_cpucapacity.
How do you distinguish '-1' in (1), (2) and 'best_cpu = -1' (3)?
In (1) and (2) you want to check if target is idle (or sched_idle) but
in (3) you probably only want to check 'recent_used_cpu'?
next prev parent reply other threads:[~2020-01-29 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 20:09 [PATCH v3 0/3] sched/fair: Capacity aware wakeup rework Valentin Schneider
2020-01-26 20:09 ` [PATCH v3 1/3] sched/fair: Add asymmetric CPU capacity wakeup scan Valentin Schneider
2020-01-28 6:22 ` Pavan Kondeti
2020-01-28 11:30 ` Valentin Schneider
2020-01-29 3:52 ` Pavan Kondeti
2020-01-29 8:16 ` Qais Yousef
2020-01-29 9:25 ` Valentin Schneider
2020-01-29 10:38 ` Dietmar Eggemann [this message]
2020-01-29 12:10 ` Valentin Schneider
2020-01-29 11:04 ` Dietmar Eggemann
2020-01-29 12:10 ` Valentin Schneider
2020-01-26 20:09 ` [PATCH v3 2/3] sched/topology: Remove SD_BALANCE_WAKE on asymmetric capacity systems Valentin Schneider
2020-01-29 16:27 ` Dietmar Eggemann
2020-01-30 11:06 ` Valentin Schneider
2020-01-26 20:09 ` [PATCH v3 3/3] sched/fair: Kill wake_cap() Valentin Schneider
2020-01-28 9:24 ` [PATCH v3 0/3] sched/fair: Capacity aware wakeup rework Dietmar Eggemann
2020-01-28 11:34 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa14491-517e-92d2-08b0-568338d75812@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=adharmap@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qperret@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®