From: Valentin Schneider <valentin.schneider@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
qperret@google.com, adharmap@codeaurora.org
Subject: Re: [PATCH v3 2/3] sched/topology: Remove SD_BALANCE_WAKE on asymmetric capacity systems
Date: Thu, 30 Jan 2020 11:06:49 +0000 [thread overview]
Message-ID: <203f41b4-6fbe-2b69-0548-02ea326b704e@arm.com> (raw)
In-Reply-To: <92f38645-c6ae-0e15-fac9-8c6064b5d4cf@arm.com>
On 29/01/2020 16:27, Dietmar Eggemann wrote:
> On 26/01/2020 21:09, Valentin Schneider wrote:
>> From: Morten Rasmussen <morten.rasmussen@arm.com>
>
> [...]
>
>> @@ -1374,18 +1374,9 @@ sd_init(struct sched_domain_topology_level *tl,
>> * Convert topological properties into behaviour.
>> */
>>
>> - if (sd->flags & SD_ASYM_CPUCAPACITY) {
>> - struct sched_domain *t = sd;
>> -
>> - /*
>> - * Don't attempt to spread across CPUs of different capacities.
>> - */
>> - if (sd->child)
>> - sd->child->flags &= ~SD_PREFER_SIBLING;
>> -
>> - for_each_lower_domain(t)
>
> It seems that with this goes the last use of for_each_lower_domain().
>
> [...]
>
Indeed, good catch. I see that was used at some point before the
select_idle_sibling() rework:
10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings()")
and our asymmetry policy saved it. I'll remove it in v4.
next prev parent reply other threads:[~2020-01-30 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 20:09 [PATCH v3 0/3] sched/fair: Capacity aware wakeup rework Valentin Schneider
2020-01-26 20:09 ` [PATCH v3 1/3] sched/fair: Add asymmetric CPU capacity wakeup scan Valentin Schneider
2020-01-28 6:22 ` Pavan Kondeti
2020-01-28 11:30 ` Valentin Schneider
2020-01-29 3:52 ` Pavan Kondeti
2020-01-29 8:16 ` Qais Yousef
2020-01-29 9:25 ` Valentin Schneider
2020-01-29 10:38 ` Dietmar Eggemann
2020-01-29 12:10 ` Valentin Schneider
2020-01-29 11:04 ` Dietmar Eggemann
2020-01-29 12:10 ` Valentin Schneider
2020-01-26 20:09 ` [PATCH v3 2/3] sched/topology: Remove SD_BALANCE_WAKE on asymmetric capacity systems Valentin Schneider
2020-01-29 16:27 ` Dietmar Eggemann
2020-01-30 11:06 ` Valentin Schneider [this message]
2020-01-26 20:09 ` [PATCH v3 3/3] sched/fair: Kill wake_cap() Valentin Schneider
2020-01-28 9:24 ` [PATCH v3 0/3] sched/fair: Capacity aware wakeup rework Dietmar Eggemann
2020-01-28 11:34 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=203f41b4-6fbe-2b69-0548-02ea326b704e@arm.com \
--to=valentin.schneider@arm.com \
--cc=adharmap@codeaurora.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®